Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduceing benchmark test run time #18787

Closed
wants to merge 1 commit into from
Closed

Reduceing benchmark test run time #18787

wants to merge 1 commit into from

Conversation

juggernaut451
Copy link
Contributor

Fix for #18778
Reduced benchmark test run time to 0.000001

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 14, 2018
@BridgeAR BridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 14, 2018
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 16, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Feb 16, 2018
@juggernaut451 @BridgeAR
test: reduce benchmark test run time
85893af 
The `millions` argument was missing.

PR-URL: nodejs#18787
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@BridgeAR
Copy link
Member

Landed in 85893af 🎉

@juggernaut451 congratulations on your first commit to Node.js!

@BridgeAR BridgeAR closed this Feb 16, 2018
@juggernaut451
Copy link
Contributor Author

@BridgeAR thanks a lot :)

MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@juggernaut451 @MylesBorins
test: reduce benchmark test run time
4cb1af2 
The `millions` argument was missing.

PR-URL: #18787
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 21, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@juggernaut451 @MylesBorins
test: reduce benchmark test run time
cf10a94 
The `millions` argument was missing.

PR-URL: #18787
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@juggernaut451 @MayaLekova
test: reduce benchmark test run time
4a64904 
The `millions` argument was missing.

PR-URL: nodejs#18787
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
@juggernaut451 @MylesBorins
test: reduce benchmark test run time
06b6507 
The `millions` argument was missing.

PR-URL: #18787
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
@juggernaut451 @MylesBorins
test: reduce benchmark test run time
a773886 
The `millions` argument was missing.

PR-URL: #18787
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 9, 2018
@juggernaut451 @MylesBorins
test: reduce benchmark test run time
0de0911 
The `millions` argument was missing.

PR-URL: #18787
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Aug 16, 2018
@juggernaut451 @MylesBorins
test: reduce benchmark test run time
ecf3616 
The `millions` argument was missing.

PR-URL: #18787
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@daynin daynin daynin approved these changes

@benjamingr benjamingr benjamingr approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@iwko iwko iwko approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@juggernaut451 @BridgeAR @Trott @daynin @benjamingr @iwko @MylesBorins @nodejs-github-bot