doc: add Yihong Wang to collaborators #18824
Conversation
Refs: nodejs#18533 Signed-off-by: Yihong Wang <[email protected]>
Trott
added
the
notable-change
Signed-off-by: Yihong Wang <[email protected]> PR-URL: nodejs#18824 Refs: nodejs#18533 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Richard Lau <[email protected]>
|
Landed in 6c9774f and close the PR. |
|
No CI? |
|
CI passed, I forgot to pasted the link, let me find it. |
Here it is: https://ci.nodejs.org/job/node-test-pull-request/13222/ |
|
Also: Welcome! :-D |
Thanks @Trott . That's the first CI I kicked off and it failed on 2 sub jobs. Because this would be my first self-landed PR, I'd like to get a all-green CI. Then I kicked off another one and got a good result. :-p The link I posted above is the second one. |
|
Ah, so you were running full CIs. That explains why the onboarding process didn't finish in 90 minutes. :-D For onboardings, it's usually enough to make sure the linter passes and maybe one other platform, and then we usually cancel the job. There's also the node-test-pull-request-lite task, which only runs LinuxOne and the linter. But those things probably aren't documented in the onboarding script, so that's probably why this happened. It's all coming together for me! |
Oops.. Good to know that. Yes, I ran a full CI. Unfortunately, I don't have second chance to do that again. For the onboarding CI stuff, no, it's not in the onboarding script. Or maybe we can have a special CI to run doc change only PR. I also ran |
|
Fwiw, when I’m onboarding people I usually let them kick off CI on an unrelated PR (that really needs it) first, then optionally too for the onboarding PR itself.
That’s more or less what we use the |
Signed-off-by: Yihong Wang <[email protected]> PR-URL: #18824 Refs: #18533 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Signed-off-by: Yihong Wang <[email protected]> PR-URL: #18824 Refs: #18533 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Signed-off-by: Yihong Wang <[email protected]> PR-URL: #18824 Refs: #18533 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Signed-off-by: Yihong Wang <[email protected]> PR-URL: nodejs#18824 Refs: nodejs#18533 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Signed-off-by: Yihong Wang <[email protected]> PR-URL: #18824 Refs: #18533 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Signed-off-by: Yihong Wang <[email protected]> PR-URL: #18824 Refs: #18533 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Signed-off-by: Yihong Wang <[email protected]> PR-URL: #18824 Refs: #18533 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Signed-off-by: Yihong Wang <[email protected]> PR-URL: #18824 Refs: #18533 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Refs: #18533
Signed-off-by: Yihong Wang [email protected]
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc