-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update description of 'clientError' event #18885
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
Issues and PRs related to the documentations.
http
Issues or PRs related to the http subsystem.
labels
Feb 20, 2018
Default behavior is to send a '400 Bad Request' response if the socket is writable. Refs: nodejs#15324
lpinca
force-pushed
the
update/client-error-description
branch
from
February 20, 2018 19:57
8df4984
to
e733af6
Compare
BridgeAR
approved these changes
Feb 21, 2018
BridgeAR
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Feb 21, 2018
daynin
approved these changes
Feb 21, 2018
cjihrig
approved these changes
Feb 21, 2018
Landed in 54cb3c5 - thanks! |
benjamingr
pushed a commit
that referenced
this pull request
Feb 23, 2018
Default behavior is to send a '400 Bad Request' response if the socket is writable. PR-URL: #18885 Refs: #15324 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Feb 26, 2018
Default behavior is to send a '400 Bad Request' response if the socket is writable. PR-URL: nodejs#18885 Refs: nodejs#15324 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Feb 26, 2018
Default behavior is to send a '400 Bad Request' response if the socket is writable. PR-URL: #18885 Refs: #15324 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Closed
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
Default behavior is to send a '400 Bad Request' response if the socket is writable. PR-URL: nodejs#18885 Refs: nodejs#15324 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 8, 2018
Default behavior is to send a '400 Bad Request' response if the socket is writable. PR-URL: #18885 Refs: #15324 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 9, 2018
Default behavior is to send a '400 Bad Request' response if the socket is writable. PR-URL: #18885 Refs: #15324 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Aug 16, 2018
Default behavior is to send a '400 Bad Request' response if the socket is writable. PR-URL: #18885 Refs: #15324 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
http
Issues or PRs related to the http subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default behavior is to send a '400 Bad Request' response if the socket is writable.
Refs: #15324
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
doc