Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add inspector usage example #19172

Merged
merged 1 commit into from
Mar 8, 2018
Merged

doc: add inspector usage example #19172

merged 1 commit into from
Mar 8, 2018

Conversation

ofrobots
Copy link
Contributor

@ofrobots ofrobots commented Mar 6, 2018 •
edited
Loading

Add a simple example showing how to use the inspector API to access
the CPU profiler.

Checklist

CI-light: https://ci.nodejs.org/view/Node.js/job/node-test-commit-light/362/ https://ci.nodejs.org/view/Node.js/job/node-test-commit-light/365/

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. inspector Issues and PRs related to the V8 inspector protocol labels Mar 6, 2018
@BridgeAR BridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 6, 2018
@BridgeAR
Copy link
Member

BridgeAR commented Mar 6, 2018

Seems like there is a linter issue @ofrobots

@ofrobots
Copy link
Contributor Author

ofrobots commented Mar 6, 2018

Fixed.

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 6, 2018
vsemozhetbyt
vsemozhetbyt reviewed Mar 6, 2018
View reviewed changes
doc/api/inspector.md Outdated

session.post('Profiler.enable', () => {
session.post('Profiler.start', () => {
// invoke business logic under meansurement here...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nit: meansurement -> measurement

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Fixed.

Trott
Trott reviewed Mar 7, 2018
View reviewed changes
doc/api/inspector.md Outdated

### CPU Profiler

Apart from debugger, various V8 Profilers are available through the DevTools
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from debugger -> Apart from the debugger perhaps?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Fixed.

@ofrobots
doc: add inspector usage example
fbf7ff9 
Add a simple example showing how to use the inspector API to access
the CPU profiler.

PR-URL: nodejs#19172
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
@ofrobots ofrobots merged commit fbf7ff9 into nodejs:master Mar 8, 2018
@ofrobots
Copy link
Contributor Author

ofrobots commented Mar 8, 2018

Landed as fbf7ff9.

@ofrobots ofrobots deleted the inspector-profile-example branch March 8, 2018 01:10
targos pushed a commit that referenced this pull request Mar 17, 2018
@ofrobots @targos
doc: add inspector usage example
0743a92 
Add a simple example showing how to use the inspector API to access
the CPU profiler.

PR-URL: #19172
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
@targos targos mentioned this pull request Mar 18, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
@ofrobots @MylesBorins
doc: add inspector usage example
84acb9f 
Add a simple example showing how to use the inspector API to access
the CPU profiler.

PR-URL: #19172
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@ofrobots @MayaLekova
doc: add inspector usage example
dd24508 
Add a simple example showing how to use the inspector API to access
the CPU profiler.

PR-URL: nodejs#19172
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
jasnell pushed a commit to jasnell/node that referenced this pull request Aug 17, 2018
@ofrobots @jasnell
doc: add inspector usage example
5ff1828 
Add a simple example showing how to use the inspector API to access
the CPU profiler.

PR-URL: nodejs#19172
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 6, 2018
@ofrobots @MylesBorins
doc: add inspector usage example
94d27e2 
Add a simple example showing how to use the inspector API to access
the CPU profiler.

Backport-PR-URL: #22380
PR-URL: #19172
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Sep 6, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt left review comments

@Trott Trott Trott left review comments

@BridgeAR BridgeAR BridgeAR approved these changes

@XadillaX XadillaX XadillaX approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@eugeneo eugeneo eugeneo approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@ofrobots @BridgeAR @eugeneo @Trott @lpinca @cjihrig @XadillaX @vsemozhetbyt @nodejs-github-bot