Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: make some changes to .editorconfig #19521

Closed
wants to merge 2 commits into from

Conversation

tniessen
Copy link
Member

  1. The src directory does not contain any JavaScript source files, so there is no need to include the directory in the rule definition.
  2. The tools directory contains JavaScript files which should be matched, most importantly tools/eslint-rules and tools/doc.

One side-effect of the second change is that the following rules now apply to some other files in the tools directory which were previously ignored:

end_of_line = lf
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true

Will this cause problems for anyone?

Checklist

The src directory does not contain any JavaScript files, so there is no
need to match it.
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Mar 21, 2018
@gibfahn
Copy link
Member

gibfahn commented Mar 27, 2018

I think @Fishrock123 may have been a user of this file

tniessen added a commit that referenced this pull request Apr 1, 2018
The src directory does not contain any JavaScript files, so there is no
need to match it.

PR-URL: #19521
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
tniessen added a commit that referenced this pull request Apr 1, 2018
PR-URL: #19521
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
@tniessen
Copy link
Member Author

tniessen commented Apr 1, 2018

Landed in 2fc60b2, 303354b.

@tniessen tniessen closed this Apr 1, 2018
targos pushed a commit that referenced this pull request Apr 2, 2018
The src directory does not contain any JavaScript files, so there is no
need to match it.

PR-URL: #19521
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
targos pushed a commit that referenced this pull request Apr 2, 2018
PR-URL: #19521
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
@targos targos mentioned this pull request Apr 4, 2018
MylesBorins pushed a commit that referenced this pull request Aug 17, 2018
The src directory does not contain any JavaScript files, so there is no
need to match it.

PR-URL: #19521
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 17, 2018
PR-URL: #19521
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants