Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url: added url fragment lookup table #17627

Closed
wants to merge 1 commit into from
Closed

url: added url fragment lookup table #17627

wants to merge 1 commit into from

Conversation

Kimeiga
Copy link
Contributor

@Kimeiga Kimeiga commented Dec 12, 2017

Percent-encoded additional characters in fragment state with new
FRAGMENT_ENCODE_SET lookup table. The fragment percent-encode set
includes the C0 control percent-encode set and code points U+0020,
U+0022, U+003C, U+003E, and U+0060.

Fixes: #17540

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

url

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v4.x whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Dec 12, 2017
@TimothyGu
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/12054/

BridgeAR
BridgeAR approved these changes Dec 12, 2017
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but it needs a rebase.

@Kimeiga
Copy link
Contributor Author

Kimeiga commented Dec 13, 2017

Finished rebasing!

@TimothyGu TimothyGu mentioned this pull request Dec 13, 2017
Closed
2 tasks
TimothyGu
TimothyGu approved these changes Dec 13, 2017
View reviewed changes
src/node_url.cc Outdated
@@ -325,7 +325,75 @@ const uint8_t C0_CONTROL_ENCODE_SET[32] = {
0x01 | 0x02 | 0x04 | 0x08 | 0x10 | 0x20 | 0x40 | 0x80
};

const uint8_t PATH_ENCODE_SET[32] = {
static const uint8_t FRAGMENT_ENCODE_SET[32] = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like there was some issues in rebasing: the static here and below should have been removed when rebasing. This could be taken care of this when landing.

@TimothyGu TimothyGu added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 13, 2017
@Kimeiga
url: added url fragment lookup table
7915bb0 
Percent-encoded additional characters in fragment state with new
FRAGMENT_ENCODE_SET lookup table. The fragment percent-encode set
includes the C0 control percent-encode set and code points U+0020,
U+0022, U+003C, U+003E, and U+0060.

Fixes: nodejs#17540
@Kimeiga
Copy link
Contributor Author

Kimeiga commented Dec 14, 2017

Removed "static" rebasing debris!

@TimothyGu
Copy link
Member

TimothyGu commented Dec 15, 2017 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-commit/14844/ (passing other than the FreeBSD infra issue)

@TimothyGu
Copy link
Member

Landed in 89bd4abeb3feaf7b4e5b3413b88a6ff52e59c9c6! 🎉

@TimothyGu TimothyGu closed this Dec 15, 2017
@TimothyGu TimothyGu removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 15, 2017
@targos
Copy link
Member

targos commented Dec 15, 2017

Commit metadata is missing

@Trott
Copy link
Member

Trott commented Dec 15, 2017

Can we fix and force-push? It's been more than 10 minutes, but less than a half hour. Things seem awfully quiet right now so I'd be OK with it.

Trott pushed a commit to Trott/io.js that referenced this pull request Dec 15, 2017
@Kimeiga @Trott
url: added url fragment lookup table
897f457 
Percent-encoded additional characters in fragment state with new
FRAGMENT_ENCODE_SET lookup table. The fragment percent-encode set
includes the C0 control percent-encode set and code points U+0020,
U+0022, U+003C, U+003E, and U+0060.

PR-URL: nodejs#17627
Fixes: nodejs#17540
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott
Copy link
Member

Trott commented Dec 15, 2017

Fixed and force-pushed in 897f457

@TimothyGu
Copy link
Member

Sorry about that 😥 Thanks @Trott for fixing it!

MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
@Kimeiga @MylesBorins
url: added url fragment lookup table
ed7f59a 
Percent-encoded additional characters in fragment state with new
FRAGMENT_ENCODE_SET lookup table. The fragment percent-encode set
includes the C0 control percent-encode set and code points U+0020,
U+0022, U+003C, U+003E, and U+0060.

PR-URL: #17627
Fixes: #17540
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2018
Merged
MylesBorins pushed a commit that referenced this pull request May 22, 2018
@Kimeiga @MylesBorins
url: added url fragment lookup table
d81a3f4 
Percent-encoded additional characters in fragment state with new
FRAGMENT_ENCODE_SET lookup table. The fragment percent-encode set
includes the C0 control percent-encode set and code points U+0020,
U+0022, U+003C, U+003E, and U+0060.

PR-URL: #17627
Fixes: #17540
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jun 14, 2018
@Kimeiga @MylesBorins
url: added url fragment lookup table
791f023 
Percent-encoded additional characters in fragment state with new
FRAGMENT_ENCODE_SET lookup table. The fragment percent-encode set
includes the C0 control percent-encode set and code points U+0020,
U+0022, U+003C, U+003E, and U+0060.

PR-URL: #17627
Fixes: #17540
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jul 9, 2018
Merged
rvagg pushed a commit that referenced this pull request Aug 16, 2018
@Kimeiga @rvagg
url: added url fragment lookup table
40a36b3 
Percent-encoded additional characters in fragment state with new
FRAGMENT_ENCODE_SET lookup table. The fragment percent-encode set
includes the C0 control percent-encode set and code points U+0020,
U+0022, U+003C, U+003E, and U+0060.

PR-URL: #17627
Fixes: #17540
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@watilde watilde watilde approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sync WHATWG URL parser with upstream standards
9 participants
@Kimeiga @TimothyGu @targos @Trott @jasnell @watilde @BridgeAR @MylesBorins @nodejs-github-bot