n-api: throw when entry point is null #20779
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
3 tasks
cjihrig
approved these changes
May 16, 2018
addaleax
approved these changes
May 16, 2018
gabrielschulhof
force-pushed
the
n-api-handle-null-init
branch
from
f33d2a1
to
99fa5a7
Compare
|
@addaleax I've changed the text of the error message to be exactly the same as the text for regular addons, i.e. "Module has no declared entry point." Can we replace both with a node_errors.h construction without the result being semver-major? |
gabrielschulhof
force-pushed
the
n-api-handle-null-init
branch
from
99fa5a7
to
a2097c7
Compare
|
Fixed lint. CI: https://ci.nodejs.org/job/node-test-pull-request/15068/ |
|
The CI failures are unrelated. |
|
Landed in 9a02de7. |
gabrielschulhof
pushed a commit
that referenced
this pull request
May 24, 2018
PR-URL: #20779 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 25, 2018
PR-URL: #20779 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
Merged
|
Should this be backported to |
4 tasks
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Jul 14, 2018
PR-URL: nodejs#20779 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 1, 2018
Backport-PR-URL: #21732 PR-URL: #20779 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Aug 16, 2018
Backport-PR-URL: #21732 PR-URL: #20779 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes