Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: specify 'dir' for directory symlinks #19049

Closed
wants to merge 1 commit into from
Closed

test: specify 'dir' for directory symlinks #19049

wants to merge 1 commit into from

Conversation

kfarnung
Copy link
Contributor

Directory symlinks in Windows require the 'dir' flag to be passed to
create the symlink correctly.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@kfarnung kfarnung self-assigned this Feb 27, 2018
@nodejs-github-bot nodejs-github-bot added addons Issues and PRs related to native addons. test Issues and PRs related to the tests. labels Feb 27, 2018
@kfarnung
Copy link
Contributor Author

kfarnung commented Feb 27, 2018 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/13402/
Reruns:
https://ci.nodejs.org/job/node-test-commit-linux-containered/2547/
https://ci.nodejs.org/job/node-test-commit-freebsd/15819/

@kfarnung
test: specify 'dir' for directory symlinks
57185eb 
Directory symlinks in Windows require the 'dir' flag to be passed to
create the symlink correctly.
@kfarnung
Copy link
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/13414/

@BridgeAR BridgeAR added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Mar 1, 2018
@kfarnung
Copy link
Contributor Author

kfarnung commented Mar 2, 2018

Landed in 148f402

@kfarnung kfarnung closed this Mar 2, 2018
@kfarnung kfarnung deleted the symlinks branch March 2, 2018 00:08
kfarnung added a commit that referenced this pull request Mar 2, 2018
@kfarnung
test: specify 'dir' for directory symlinks
148f402 
Directory symlinks in Windows require the 'dir' flag to be passed to
create the symlink correctly.

PR-URL: #19049
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
addaleax pushed a commit to addaleax/node that referenced this pull request Mar 5, 2018
@kfarnung @addaleax
test: specify 'dir' for directory symlinks
fd27165 
Directory symlinks in Windows require the 'dir' flag to be passed to
create the symlink correctly.

PR-URL: nodejs#19049
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
kfarnung added a commit to kfarnung/node-chakracore that referenced this pull request Mar 6, 2018
@kfarnung
test: specify 'dir' for directory symlinks
4639b54 
Directory symlinks in Windows require the 'dir' flag to be passed to
create the symlink correctly.

PR-URL: nodejs/node#19049
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
kfarnung added a commit to kfarnung/node-chakracore that referenced this pull request Mar 6, 2018
@kfarnung
test: specify 'dir' for directory symlinks
3ae7caa 
Directory symlinks in Windows require the 'dir' flag to be passed to
create the symlink correctly.

PR-URL: nodejs/node#19049
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 6, 2018
Merged
kfarnung added a commit to kfarnung/node-chakracore that referenced this pull request Mar 6, 2018
@kfarnung
test: specify 'dir' for directory symlinks
7993348 
Directory symlinks in Windows require the 'dir' flag to be passed to
create the symlink correctly.

PR-URL: nodejs/node#19049
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
kfarnung added a commit to kfarnung/node-chakracore that referenced this pull request Mar 7, 2018
@kfarnung
test: specify 'dir' for directory symlinks
dc0de49 
Directory symlinks in Windows require the 'dir' flag to be passed to
create the symlink correctly.

PR-URL: nodejs/node#19049
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@kfarnung @MayaLekova
test: specify 'dir' for directory symlinks
0b76f2e 
Directory symlinks in Windows require the 'dir' flag to be passed to
create the symlink correctly.

PR-URL: nodejs#19049
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
jasnell pushed a commit to jasnell/node that referenced this pull request Aug 17, 2018
@kfarnung @jasnell
test: specify 'dir' for directory symlinks
eb03707 
Directory symlinks in Windows require the 'dir' flag to be passed to
create the symlink correctly.

PR-URL: nodejs#19049
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 6, 2018
@kfarnung @MylesBorins
test: specify 'dir' for directory symlinks
61dd5b7 
Directory symlinks in Windows require the 'dir' flag to be passed to
create the symlink correctly.

Backport-PR-URL: #22380
PR-URL: #19049
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Sep 6, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@richardlau richardlau richardlau approved these changes

@XadillaX XadillaX XadillaX approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

@danbev danbev danbev approved these changes

Assignees

@kfarnung kfarnung

Labels
addons Issues and PRs related to native addons. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@kfarnung @danbev @jasnell @lpinca @cjihrig @XadillaX @richardlau @BridgeAR @nodejs-github-bot