Refactor test-tls-0-dns-altname #18803
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamingr
approved these changes
Feb 15, 2018
There was a problem hiding this comment.
Thank you so much for doing this :) Welcome to the project.
What will happen now is that collaborators will review this PR for 72 hours and then (if no objections arise) it will land.
If you feel like it - feel free to check https://github.com/nodejs/node/blob/master/CONTRIBUTING.md and specifically the section about how commit messages might look. Amending your commit message is explained there too. If you don't feel like it - a collaborator will do this for you when landing since this is your first contribution
richardlau
approved these changes
Feb 16, 2018
|
Thank you @benjamingr |
jasnell
approved these changes
Feb 16, 2018
BridgeAR
approved these changes
Feb 16, 2018
BridgeAR
added
author ready
juggernaut451
force-pushed
the
refactorTestTls0DnsAltname
branch
from
83d2ecd
to
a21180f
Compare
|
Failure in CI appears unrelated. |
jasnell
pushed a commit
that referenced
this pull request
Feb 17, 2018
PR-URL: #18803 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
|
Landed in 760f86c |
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2018
PR-URL: #18803 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2018
PR-URL: #18803 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2018
PR-URL: #18803 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
PR-URL: nodejs#18803 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 7, 2018
PR-URL: #18803 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 7, 2018
PR-URL: #18803 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 9, 2018
PR-URL: #18803 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Aug 16, 2018
PR-URL: #18803 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test
Changes that are done in file are :
test: good-second-contribution — tracking tests that need some more 💘 #14544