Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky repl-timeout-throw #18692

Closed
wants to merge 1 commit into from
Closed

test: fix flaky repl-timeout-throw #18692

wants to merge 1 commit into from

Conversation

santigimeno
Copy link
Member

Don't disconnect the child until all exceptions are thrown.

Fixes: #18659

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 10, 2018
@santigimeno
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/13075/

bnoordhuis
bnoordhuis approved these changes Feb 10, 2018
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change in and of itself even if it doesn't fix the flakiness (but I bet it does.)

test/sequential/test-repl-timeout-throw.js Outdated
@@ -13,6 +13,8 @@ child.stdout.setEncoding('utf8');
child.stdout.on('data', function(c) {
process.stdout.write(c);
stdout += c;
if (stdout.indexOf('> THROW 2') !== -1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.includes()?

@santigimeno
test: fix flaky repl-timeout-throw
e701d33 
Don't disconnect the child until all exceptions are thrown.

Fixes: nodejs#18659
@santigimeno
Copy link
Member Author

Updated to use includes(). CI: https://ci.nodejs.org/job/node-test-pull-request/13077/. Thanks

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 10, 2018
@BridgeAR BridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 10, 2018
@BridgeAR
Copy link
Member

Landed in 01d0491 🎉

@BridgeAR BridgeAR closed this Feb 10, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Feb 10, 2018
@santigimeno @BridgeAR
test: fix flaky repl-timeout-throw
01d0491 
Don't disconnect the child until all exceptions are thrown.

Fixes: nodejs#18659

PR-URL: nodejs#18692
Fixes: nodejs#18659
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@santigimeno @MylesBorins
test: fix flaky repl-timeout-throw
28207e3 
Don't disconnect the child until all exceptions are thrown.

Fixes: #18659

PR-URL: #18692
Fixes: #18659
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@santigimeno @MylesBorins
test: fix flaky repl-timeout-throw
6dd8e2a 
Don't disconnect the child until all exceptions are thrown.

Fixes: #18659

PR-URL: #18692
Fixes: #18659
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@santigimeno @MylesBorins
test: fix flaky repl-timeout-throw
6790a72 
Don't disconnect the child until all exceptions are thrown.

Fixes: #18659

PR-URL: #18692
Fixes: #18659
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 21, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@santigimeno @MylesBorins
test: fix flaky repl-timeout-throw
72d7159 
Don't disconnect the child until all exceptions are thrown.

Fixes: #18659

PR-URL: #18692
Fixes: #18659
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@santigimeno @MayaLekova
test: fix flaky repl-timeout-throw
05a3997 
Don't disconnect the child until all exceptions are thrown.

Fixes: nodejs#18659

PR-URL: nodejs#18692
Fixes: nodejs#18659
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
@santigimeno @MylesBorins
test: fix flaky repl-timeout-throw
0c732b8 
Don't disconnect the child until all exceptions are thrown.

Fixes: #18659

PR-URL: #18692
Fixes: #18659
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
rvagg pushed a commit that referenced this pull request Aug 16, 2018
@santigimeno @rvagg
test: fix flaky repl-timeout-throw
4eca50a 
Don't disconnect the child until all exceptions are thrown.

Fixes: #18659

PR-URL: #18692
Fixes: #18659
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky test-repl-timeout-throw
6 participants
@santigimeno @BridgeAR @bnoordhuis @cjihrig @MylesBorins @nodejs-github-bot