Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: add log output to crashes #20295

Closed
wants to merge 2 commits into from
Closed

tools: add log output to crashes #20295

wants to merge 2 commits into from

Conversation

BridgeAR
Copy link
Member

@nodejs/build PTAL

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. labels Apr 25, 2018
@BridgeAR BridgeAR added build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. and removed test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. labels Apr 25, 2018
@BridgeAR

This comment has been minimized.

Sign in to view
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 25, 2018
@richardlau richardlau mentioned this pull request Apr 25, 2018
Closed
2 tasks
@BridgeAR
Copy link
Member Author

CI https://ci.nodejs.org/job/node-test-pull-request/14507/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 26, 2018
@rvagg
Copy link
Member

rvagg commented Apr 26, 2018

ping @Trott and @refack who were tinkering here recently

refack
refack suggested changes Apr 27, 2018
View reviewed changes
tools/test.py Outdated
@@ -299,7 +299,7 @@ def HasRun(self, output):
if output.HasCrashed():
self.severity = 'crashed'
exit_code = output.output.exit_code
self.traceback = "oh no!\nexit code: " + PrintCrashed(exit_code)
self.traceback += "oh no!\nexit code: " + PrintCrashed(exit_code)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO best solution is to drop this whole line and the prev line.

  • L290 will set the exit code (it's new code)
  • L300 will indicate crash

Copy link
Member Author

@BridgeAR BridgeAR Apr 27, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree because the exit code would not be visible in that case anymore. You are right.

@BridgeAR
Copy link
Member Author

Comment addressed.

CI https://ci.nodejs.org/job/node-test-pull-request/14545/

@addaleax addaleax removed the fast-track PRs that do not need to wait for 48 hours to land. label Apr 27, 2018
@addaleax
Copy link
Member

CI has only known flakes :)

@refack Does this LGTY?

refack
refack approved these changes Apr 27, 2018
View reviewed changes
Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@addaleax
Copy link
Member

Landed in a4b4854

@addaleax addaleax closed this Apr 27, 2018
addaleax pushed a commit that referenced this pull request Apr 27, 2018
@BridgeAR @addaleax
tools: add log output to crashes
a4b4854 
PR-URL: #20295
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 4, 2018
@BridgeAR @MylesBorins
tools: add log output to crashes
8ddbac2 
PR-URL: #20295
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@MylesBorins MylesBorins mentioned this pull request May 8, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Aug 17, 2018
@BridgeAR @MylesBorins
tools: add log output to crashes
c56aafd 
PR-URL: #20295
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Aug 17, 2018
Merged
@BridgeAR BridgeAR deleted the log-everything branch January 20, 2020 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack approved these changes

@jasnell jasnell jasnell approved these changes

@mmarchini mmarchini mmarchini approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@richardlau richardlau richardlau approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.