Skip to content

Commit

Permalink
build: make lint-ci work properly on Linux make
Browse files Browse the repository at this point in the history
PR-URL: #19746
Reviewed-By: Joyee Cheung <[email protected]>
  • Loading branch information
rvagg committed Aug 16, 2018
1 parent 4f3bf04 commit 020057a
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -1072,7 +1072,8 @@ lint-js-ci:
jslint-ci: lint-js-ci
@echo "Please use lint-js-ci instead of jslint-ci"

LINT_CPP_ADDON_DOC_FILES = $(wildcard test/addons/??_*/*.cc test/addons/??_*/*.h)
LINT_CPP_ADDON_DOC_FILES_GLOB = test/addons/??_*/*.cc test/addons/??_*/*.h
LINT_CPP_ADDON_DOC_FILES = $(wildcard $(LINT_CPP_ADDON_DOC_FILES_GLOB))
LINT_CPP_EXCLUDE ?=
LINT_CPP_EXCLUDE += src/node_root_certs.h
LINT_CPP_EXCLUDE += $(LINT_CPP_ADDON_DOC_FILES)
Expand Down Expand Up @@ -1113,7 +1114,7 @@ tools/.cpplintstamp: $(LINT_CPP_FILES)

lint-addon-docs: test/addons/.docbuildstamp
@echo "Running C++ linter on addon docs..."
@$(PYTHON) tools/cpplint.py --filter=$(ADDON_DOC_LINT_FLAGS) $(LINT_CPP_ADDON_DOC_FILES)
@$(PYTHON) tools/cpplint.py --filter=$(ADDON_DOC_LINT_FLAGS) $(LINT_CPP_ADDON_DOC_FILES_GLOB)

cpplint: lint-cpp
@echo "Please use lint-cpp instead of cpplint"
Expand Down

0 comments on commit 020057a

Please sign in to comment.