Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: minor refactoring #19130

Closed
wants to merge 1 commit into from
Closed

test: minor refactoring #19130

wants to merge 1 commit into from

Conversation

ken23421
Copy link
Contributor

@ken23421 ken23421 commented Mar 4, 2018

change to arrow functions

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@ken23421
test: minor refactoring
aff81b2 
change to arrow functions
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 4, 2018
@gibfahn
Copy link
Member

gibfahn commented Mar 5, 2018 •
edited
Loading

Looks good, but needs a manual test as CI doesn't test internet tests.

@gibfahn
Copy link
Member

gibfahn commented Mar 5, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/218/

@ken23421
Copy link
Contributor Author

ken23421 commented Mar 5, 2018 •
edited by tniessen
Loading

@gibfahn Thanks for your comment. I tested it with the following command, and the result looks ok.

$ python tools/test.py -J --mode=release test/internet/test-http-https-default-ports
[00:01|% 100|+   1|-   0]: Done

Do you have other suggestion of the manual test? Thank you.

@gibfahn
Copy link
Member

gibfahn commented Mar 5, 2018

Do you have other suggestion of the manual test? Thank you.

Nope that's perfect, just wanted to make sure someone had tried it. Thanks!

@BridgeAR BridgeAR added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Mar 6, 2018
@ken23421
Copy link
Contributor Author

ken23421 commented Mar 8, 2018

Thanks @gibfahn
Wondering is there anything else TBD before landing?

@gibfahn
Copy link
Member

gibfahn commented Mar 9, 2018

Landing...

@priyank-p priyank-p mentioned this pull request Mar 9, 2018
Closed
@gibfahn
Copy link
Member

gibfahn commented Mar 9, 2018

Landed in 06e09b6

@gibfahn gibfahn closed this Mar 9, 2018
gibfahn pushed a commit that referenced this pull request Mar 9, 2018
@ken23421 @gibfahn
test: refactor http-https-default-ports
06e09b6 
Use arrow functions.

PR-URL: #19130
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@gibfahn
Copy link
Member

gibfahn commented Mar 9, 2018

@ken23421 Thanks for the PR, and congratulations on becoming a Node.js Contributor 🎉 !

@gibfahn gibfahn mentioned this pull request Mar 9, 2018
Closed
@ken23421
Copy link
Contributor Author

@gibfahn Thanks a lot for your help :)

targos pushed a commit that referenced this pull request Mar 17, 2018
@ken23421 @targos
test: refactor http-https-default-ports
7ebfb39 
Use arrow functions.

PR-URL: #19130
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@targos targos mentioned this pull request Mar 18, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
@ken23421 @MylesBorins
test: refactor http-https-default-ports
38eb432 
Use arrow functions.

PR-URL: #19130
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@ken23421 @MayaLekova
test: refactor http-https-default-ports
2c42aaa 
Use arrow functions.

PR-URL: nodejs#19130
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
jasnell pushed a commit to jasnell/node that referenced this pull request Aug 17, 2018
@ken23421 @jasnell
test: refactor http-https-default-ports
b3e4775 
Use arrow functions.

PR-URL: nodejs#19130
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 6, 2018
@ken23421 @MylesBorins
test: refactor http-https-default-ports
e1e6a09 
Use arrow functions.

Backport-PR-URL: #22380
PR-URL: #19130
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Sep 6, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@maclover7 maclover7 maclover7 approved these changes

@tniessen tniessen tniessen approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@gibfahn gibfahn gibfahn approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@ken23421 @gibfahn @jasnell @cjihrig @maclover7 @tniessen @gireeshpunathil @BridgeAR @nodejs-github-bot