-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add RegExp Unicode Property Escapes to intl #19052
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
Issues and PRs related to the documentations.
i18n-api
Issues and PRs related to the i18n implementation.
labels
Feb 28, 2018
CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/202/ (both green) |
lpinca
approved these changes
Feb 28, 2018
jasnell
approved these changes
Feb 28, 2018
TimothyGu
approved these changes
Mar 1, 2018
benjamingr
approved these changes
Mar 1, 2018
cjihrig
approved these changes
Mar 1, 2018
BridgeAR
added
fast-track
PRs that do not need to wait for 48 hours to land.
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
labels
Mar 1, 2018
vsemozhetbyt
added a commit
that referenced
this pull request
Mar 2, 2018
PR-URL: #19052 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Landed in d3af120 |
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Mar 5, 2018
PR-URL: nodejs#19052 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
PR-URL: nodejs#19052 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
jasnell
pushed a commit
to jasnell/node
that referenced
this pull request
Aug 17, 2018
PR-URL: nodejs#19052 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 6, 2018
Backport-PR-URL: #22380 PR-URL: #19052 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
fast-track
PRs that do not need to wait for 48 hours to land.
i18n-api
Issues and PRs related to the i18n implementation.
v8 engine
Issues and PRs related to the V8 dependency.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
doc, intl
RegExp Unicode Property Escapes are at stage 4 and will be included in ES2018. They are available since V8 6.4 without a flag so they will be unflagged in Node.js v10. They are also available under the
--harmony_regexp_property
flag in Node.js v6-v9 and under the--harmony
flag in Node.js v8-v9.So it seems we should already warn about this and maybe backport these notes till v6 LTS.
Simple test:
I am not sure if this suffices to state full support also for
system-icu
, please check and correct me if this is needed.Additional refs:
https://mathiasbynens.be/notes/es-unicode-property-escapes
https://mathiasbynens.be/notes/es-regexp-proposals#unicode-property-escapes
http://exploringjs.com/es2018-es2019/ch_regexp-unicode-property-escapes.html
https://ponyfoo.com/articles/regular-expressions-post-es6#unicode-property-escapes
Unfortunately, still no info in MDN RegExp page to link to.