Conversation
Contributor
mslipper
commented
Sep 29, 2022
mslipper
commented
- fix(ct): bug in L2OutputOracle constructor (fix(ct): bug in L2OutputOracle constructor #3322)
- proxyd: Add customizable whitelist error message (proxyd: Add customizable whitelist error message #3544)
- proxyd: Add batch size metric and configurable max (proxyd: Add batch size metric and configurable max #3545)
- chore: Upgrade op-chain-ops dependencies
- chore: Upgrade op-node dependencies
- chore: Upgrade op-proposer dependencies
- chore: Upgrade op-batcher dependencies
- chore: Upgrade op-e2e dependencies
- fix: add semver to erc20 factory (fix: add semver to erc20 factory #3543)
- contracts-periphery: remove ownable upgradable from erc721 factory (contracts-periphery: remove ownable upgradable from erc721 factory #3541)
- op-node: Fix OPB-10 (op-node: Fix OPB-10 #3548)
- Codecov tweaks (Codecov tweaks #3546)
- chore: Ignore .t.sol and bindings in codecov (chore: Ignore .t.sol and bindings in codecov #3552)
- op-chain-ops: implement withdrawal hashing (op-chain-ops: implement withdrawal hashing #3469)
- feat(ctb): spacer validation task (feat(ctb): spacer validation task #3533)
- fix(ctp): post-audit cleanup for the erc721 bridge (fix(ctp): post-audit cleanup for the erc721 bridge #3549)
- circleci: delete extra op-chain-ops tests (circleci: delete extra op-chain-ops tests #3556)
- docs(ctb): add versioning rules (docs(ctb): add versioning rules #3534)
- ctp: Bump version in drip checks (ctp: Bump version in drip checks #3567)
- fix(dtl): consistency checks for L1 sync (fix(dtl): consistency checks for L1 sync #3356)
- op-node: Fix OPB-07 (op-node: Fix OPB-07 #3547)
- feat(cmn): keep raw body in requests (feat(cmn): keep raw body in requests #3550)
- ci: Delete contract-artifacts-bedrock job (ci: Delete contract-artifacts-bedrock job #3565)
- ctp: remove unnecessary require (ctp: remove unnecessary require #3572)
- op-chain-ops: use PoS consensus in simulated backend in deployer and genesis (op-chain-ops: use PoS consensus in simulated backend in deployer and genesis #3569)
- chore: Upgrade op-chain-ops dependencies
- chore: Upgrade op-node dependencies
- chore: Upgrade op-proposer dependencies
- chore: Upgrade op-batcher dependencies
- chore: Upgrade op-e2e dependencies
- op-node: Cleanup calldata source API (op-node: Cleanup calldata source API #3532)
- ci: Docker login on push (ci: Docker login on push #3559)
- feat(ctb): more defensive value check (feat(ctb): more defensive value check #3571)
- op-chain-ops: address aliasing helpers (op-chain-ops: address aliasing helpers #3562)
- contracts-governance: make the governance token immutable (contracts-governance: make the governance token immutable #3566)
- hardhat-deploy-config: easier config (hardhat-deploy-config: easier config #3564)
- chore: Disable PR commenting by codecov bot (chore: Disable PR commenting by codecov bot #3574)
- ci: Use workspace rather than cache (ci: Use workspace rather than cache #3573)
- deployer: expose deployments (deployer: expose deployments #3575)
- ci: Fix Hive artifacts (ci: Fix Hive artifacts #3577)
- ci: Fix contracts tests (ci: Fix contracts tests #3580)
- ci: Remove publish dependencies (ci: Remove publish dependencies #3578)
- contracts-bedrock: fuzz L2ToL1MessagePasser (contracts-bedrock: fuzz L2ToL1MessagePasser #3527)
- ci: Add codecov flags per codebase (ci: Add codecov flags per codebase #3568)
- feat(ctb): no refunds (feat(ctb): no refunds #3535)
- ops: fund deployer accounts for local deployment (ops: fund predeploy deployer accounts for local deployment #3576)
- feat(ctp): no refunds for NFTs (feat(ctp): no refunds for NFTs #3582)
- op-e2e: e2eutils package for new action testing setup (op-e2e: e2eutils package for new action testing setup #3586)
- op-node: Rename uint642big -> uint64ToBig (op-node: Rename uint642big -> uint64ToBig #3591)
- ci: Run all tests when check-changed fails (ci: Run all tests when check-changed fails #3595)
- op-node: Switch L1 Retrieval to pull based
- op-node: Switch L1 Traversal to a pull based model
- ctp: fixup deploy scripts for the nft bridge (ctp: fixup deploy scripts for the nft bridge #3570)
- op-node: Switch channel bank to be pull based
- op-node: Switch channel in reader to a pull based stage
- op-node: Switch batch queue to be pull based
- op-node: Switch attributes queue to be pull based (op-node: Switch attributes queue to be pull based #3598)
- op-e2e/actions: action tests base test util (op-e2e/actions: action tests base test util #3588)
* fix(ct): bug in L2OutputOracle constructor Fixes a small bug in the L2OutputOracle constructor where an assertion was being made about the wrong value. Unlikely that this would've caused any significant issues but worth fixing anyway. * Update l1genesis generation code Puts the genesis timestamp inside the simulator, and updates the simulator code to properly wait for blocks to be mined. See the comments in deployer.go and layer_one.go. * Update gas snapshot Co-authored-by: Matthew Slipper <me@matthewslipper.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* proxyd: Add customizable whitelist error message Alchemy is asking for this so that we can include their affiliate link. * add missing test case * fix error message * goimports
* proxyd: Add batch size metric and configurable max The max batch size will be overwritten if it is over `MaxBatchRPCCallsHardLimit`. Builds on #3544. * changeset * fix lint * fix test
* contracts-bedrock: add semver to erc20 factory * op-bindings: regenerate Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
…3541) The ownable upgradable modifier was not used anywhere in the contract. The erc20 factory does not follow that pattern. This change simplifies things by moving values to immutables instead of being in storage. This is a cleanup PR before migrating these contracts to `contracts-bedrock`. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* op-node: Fix OPB-10 Fixes OPB-10: No Checks for Deposit Transaction Type When Calling `L1InfoDepositTxData()`. This PR adds a check in `blockToBatch` that checks the type of the first transaction in the block, and returns an error if it isn't a deposit transaction. * goimports Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* ci: Ignore l2geth coverage reports * ci: Upload coverage reports in js-lint-test Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* op-chain-ops: implement withdrawal hashing Implement both the new hashing scheme and the legacy hashing for withdrawals so that the withdrawals can be migrated. Also implement encoding and decoding of the withdrawals * more tests * op-chain-ops: code review fixes * op-chain-ops: fix message passer Now that the old message passer is being kept in the L2 state, be sure to the use legacy address. The new message passer is at a different address.
Introduces a new task for validating the correctness of spacer variables. Prevents future developers from accidentally moving spacers. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
The tests run as part of `bedrock-go-tests` so no need to have a task specific for `op-chain-ops`. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Adds versioning rules to the Bedrock contracts package. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Adds consistency checks for L1 syncing nodes in the DTL. One of my personal nodes seemed to halt with this error, so fixing it. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* op-node: Fix OPB-07 Fixes Sigma Prime audit issue OPB-07: Private Key Stored Without Encryption. This PR requires reading the sequencer private key from an environment variable rather than a file on disk. Fixes ENG-2616 * fix devnet * delete superfluous file Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Minor modification that puts the raw body as a string on the request object. Useful for applications where the raw body is required rather than the parsed JSON body as given by bodyParser. For example, this is useful when verifying GitHub webhooks. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This job isn't needed anymore since we're compiling the artifacts into the bindings. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
There was a leftover require from when the contract was `initializable`. This commit removes that because it is no longer needed. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
…genesis (#3569) * op-chain-ops: use PoS consensus in simulated backend in deployer, and add PoS option to genesis * op-geth: update dependencies for new simulated backend option and ttd check fix Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* feat(ctb): no refunds Removes refunds from the StandardBridge flow. * regenerate bindings Co-authored-by: Matthew Slipper <me@matthewslipper.com>
This will make it easier to test the e2e nft deployment scripts. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Removes refunds for failed NFT deposits. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This new name is more idiomatic in go and avoids a confusion with the '642'.
`check-changed` fails on stacked PRs. This PR updated the CircleCI config to simply run tests if check-changed fails in order to prevent PRs from getting blocked.
This makes the L1 Retrieval a purely pull based stage. This commit required large modifications to the channel bank stage in order for the channel bank to maintain it's own progress.
The L1 Retrieval stage is now responsible for pulling data from the L1 Traversal stage. In addition, the pipeline is responsible for advancing the state of the L1 Traversal stage. The L1 Traversal stage only provides access to the current L1 block once - it pretends to be a queue that is consumed from.
* ctp: fixup deploy scripts for the nft bridge The most important one is the deploy script for the `Proxy` that will end up at the predeploy on L2. There are specific checks for the correct deployer account being used. Will likely require some changes to the hardhat config when doing the actual deployment. * ctp: update deploy scripts * ctp: update deploy scripts * ctp: move away from deterministic deployments * op: deployments * fixes * deploy-script: refactor * deploy: comments
This again requires a fair amount of changes to channel_in_reader.go for the channel in reader to maintain its progress state.
Like the rest of the changes, this also required modifications to the next stage - the batch queue in order for it to manage the progress API. This commit required even more changes than usual. I changed the pipeline to be reset to a common starting point and now use the L2SafeHead block to filter out adding batches & L1 blocks to the batch queue.
The attributes queue actually had pretty few modifications to work with the progress API. The logic of switching the batch queue over was a bit more complex because the batch queue is very stateful, but still not the worst.
The progress API is very nearly removed from the engine queue stage.
op-node: Switch batch queue to be pull based
op-node: Switch channel bank and channel in reader to a pull based stage
op-node: Switch L1 Retrieval to pull based
op-node: Switch L1 Traversal to a pull based model
* op-e2e/actions: action tests base test util * actions: extend action testing doc comments * actions: docstring about format and args Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
🦋 Changeset detectedLatest commit: 7b5fb40 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
2-reviewers
C-protocol-critical
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.