Skip to content

op-node: Fix OPB-07#3547

Merged
mergify[bot] merged 5 commits intodevelopfrom
bugfix/opb-07
Sep 26, 2022
Merged

op-node: Fix OPB-07#3547
mergify[bot] merged 5 commits intodevelopfrom
bugfix/opb-07

Conversation

@mslipper
Copy link
Contributor

@mslipper mslipper commented Sep 23, 2022

Fixes Sigma Prime audit issue OPB-07: Private Key Stored Without Encryption. This PR requires reading the sequencer private key from an environment variable rather than a file on disk.

Fixes ENG-2616

@mslipper
op-node: Fix OPB-07
12b9e0b 
Fixes Sigma Prime audit issue OPB-07: Private Key Stored Without Encryption. This PR requires reading the sequencer private key from an environment variable rather than a file on disk.

Fixes ENG-2616
@changeset-bot
Copy link

changeset-bot bot commented Sep 23, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 18f92e5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify
Copy link
Contributor

mergify bot commented Sep 23, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

tynes
tynes reviewed Sep 25, 2022
View reviewed changes
@tynes
Copy link
Contributor

tynes commented Sep 26, 2022

I'm guessing that the hive dockerfiles are now breaking..

@mslipper
Copy link
Contributor Author

mslipper commented Sep 26, 2022

Correct. Will fix that in a separate PR.

mslipper added a commit to ethereum-optimism/hive that referenced this pull request Sep 26, 2022
@mslipper
Use sequencer key environment variable
aae372d 
The SP audit identified an issue with the sequencer key being unencrypted on disk. To fix that, we updated the op-node to read the key from an env var. This PR updates Hive to do the same. Don't merge it until ethereum-optimism/optimism#3547 is merged.
@mslipper mslipper mentioned this pull request Sep 26, 2022
Merged
@mslipper
Copy link
Contributor Author

mslipper commented Sep 26, 2022

ethereum-optimism/hive#44 fixes this in Hive.

@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit dee7074 into develop Sep 26, 2022
@mergify mergify bot deleted the bugfix/opb-07 branch September 26, 2022 18:36
@mergify mergify bot removed the on-merge-train label Sep 26, 2022
mslipper added a commit to ethereum-optimism/hive that referenced this pull request Sep 26, 2022
@mslipper
Use sequencer key environment variable (#44)
e33e80d 
* Use sequencer key environment variable

The SP audit identified an issue with the sequencer key being unencrypted on disk. To fix that, we updated the op-node to read the key from an env var. This PR updates Hive to do the same. Don't merge it until ethereum-optimism/optimism#3547 is merged.

* fix 0x

* upgrade deps
This was referenced Sep 29, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tynes tynes tynes left review comments

+2 more reviewers

@trianglesphere trianglesphere trianglesphere approved these changes

@protolambda protolambda protolambda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mslipper @tynes @trianglesphere @protolambda