op-chain-ops: address aliasing helpers#3562
Conversation
|
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
github-actions
bot
added
2-reviewers
A-pkg-contracts-bedrock
|
Hey @tynes! This PR has merge conflicts. Please fix them before continuing review. |
Implement address aliasing helpers in go. Fuzz them to make sure that roundtrip aliasing is reliable. Add foundry fuzz tests that are used to generate test vectors. Note that the JS implementation does not take into account the modular arithmetic, I do not believe that it is used anywhere important currently. See: https://github.com/ethereum-optimism/optimism/blob/develop/packages/core-utils/src/optimism/alias.ts Perhaps we should move our differential fuzzing to use go instead of typescript or along with the typescript because most utilities that we wrote in JS are now also written in go.
tynes
force-pushed
the
feat/address-aliasing
branch
from
3f9a298 to
cef23fa
Compare
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
3 participants
Description
Implement address aliasing helpers in go. Fuzz them to make sure that roundtrip aliasing is reliable. Add foundry fuzz tests that are used to generate test vectors.
Note that the JS implementation does not take into account the modular arithmetic, I do not believe that it is used anywhere important currently.
See:
https://github.com/ethereum-optimism/optimism/blob/develop/packages/core-utils/src/optimism/alias.ts
Perhaps we should move our differential fuzzing to use go instead of typescript or along with the typescript because most utilities that we wrote in JS are now also written in go.