op-node: Switch batch queue to be pull based#3597
Merged
mslipper merged 2 commits intojg/channel_in_readerfrom Sep 28, 2022
Merged
op-node: Switch batch queue to be pull based#3597mslipper merged 2 commits intojg/channel_in_readerfrom
mslipper merged 2 commits intojg/channel_in_readerfrom
Conversation
|
Contributor
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
The attributes queue actually had pretty few modifications to work with the progress API. The logic of switching the batch queue over was a bit more complex because the batch queue is very stateful, but still not the worst.
trianglesphere
force-pushed
the
jg/channel_in_reader
branch
from
2c31590 to
94958ab
Compare
trianglesphere
force-pushed
the
jg/batchqueue
branch
from
2c71de4 to
48b7cc5
Compare
protolambda
approved these changes
Sep 28, 2022
Comment on lines
+78
to
+80
| // This is to handle the special case of startup. At startup we call Reset & include | ||
| // the L1 origin. That is the only time where immediately after `Reset` is called | ||
| // originBehind is false. |
The progress API is very nearly removed from the engine queue stage.
mslipper
approved these changes
Sep 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The attributes queue actually had pretty few modifications to work with the progress API. The logic of switching the batch queue over was a bit more complex because the batch queue is very stateful, but still not the worst.
Metadata