feat(ctb): more defensive value check#3571
Merged
mergify[bot] merged 3 commits intodevelopfrom Sep 26, 2022
Merged
Conversation
🦋 Changeset detectedLatest commit: c0728ea The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
2-reviewers
A-pkg-contracts-bedrock
tynes
approved these changes
Sep 26, 2022
maurelian
approved these changes
Sep 26, 2022
Contributor
maurelian
left a comment
maurelian
left a comment
There was a problem hiding this comment.
LGTM. I agree that having the check in the child contract was inconsistent and that we should stick to this pattern in the future.
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
maurelian
requested changes
Sep 26, 2022
packages/contracts-bedrock/contracts/universal/StandardBridge.sol
Outdated
Show resolved
Hide resolved
maurelian
reviewed
Sep 26, 2022
smartcontracts
force-pushed
the
sc/ctb-defensive-value
branch
from
0778243 to
59086ce
Compare
Moves the msg.value == amount check when bridging ETH deeper into the call stack. Has the effect of making the function less of a footgun for future developers.
smartcontracts
force-pushed
the
sc/ctb-defensive-value
branch
from
59086ce to
65d5abb
Compare
maurelian
approved these changes
Sep 26, 2022
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves the msg.value == amount check when bridging ETH deeper into the call stack. Has the effect of making the function less of a footgun for future developers.