Skip to content

proxyd: Add customizable whitelist error message#3544

Merged
mslipper merged 5 commits intodevelopfrom
feat/proxyd-whitelist-msg
Sep 23, 2022
Merged

proxyd: Add customizable whitelist error message#3544
mslipper merged 5 commits intodevelopfrom
feat/proxyd-whitelist-msg

Conversation

@mslipper
Copy link
Contributor

Alchemy is asking for this so that we can include their affiliate link.

@changeset-bot
Copy link

changeset-bot bot commented Sep 23, 2022

🦋 Changeset detected

Latest commit: 5e353ef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/proxyd Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mergify
Copy link
Contributor

mergify bot commented Sep 23, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@mslipper mslipper requested review from Inphi and tynes September 23, 2022 18:56
Alchemy is asking for this so that we can include their affiliate link.
@mslipper mslipper force-pushed the feat/proxyd-whitelist-msg branch from 1932a24 to b41170f Compare September 23, 2022 18:56
@tynes
Copy link
Contributor

tynes commented Sep 23, 2022

Generally looks good to me, how did you confirm this works as expected?

@mslipper
Copy link
Contributor Author

It's tested as part of the integration tests. The itests boot up the server, which modifies the messages.

@mslipper
Copy link
Contributor Author

Just realized that the whitelist custom message case was not tested - just fixed that.

mslipper added a commit that referenced this pull request Sep 23, 2022
The max batch size will be overwritten if it is over `MaxBatchRPCCallsHardLimit`.

Builds on #3544.
mslipper added a commit that referenced this pull request Sep 23, 2022
The max batch size will be overwritten if it is over `MaxBatchRPCCallsHardLimit`.

Builds on #3544.
@mslipper mslipper merged commit 6bb35fd into develop Sep 23, 2022
@mslipper mslipper deleted the feat/proxyd-whitelist-msg branch September 23, 2022 20:21
mslipper added a commit that referenced this pull request Sep 23, 2022
The max batch size will be overwritten if it is over `MaxBatchRPCCallsHardLimit`.

Builds on #3544.
mslipper added a commit that referenced this pull request Sep 23, 2022
* proxyd: Add batch size metric and configurable max

The max batch size will be overwritten if it is over `MaxBatchRPCCallsHardLimit`.

Builds on #3544.

* changeset

* fix lint

* fix test
This was referenced Sep 29, 2022
jelias2 pushed a commit to ethereum-optimism/infra that referenced this pull request Jun 11, 2024
* proxyd: Add batch size metric and configurable max

The max batch size will be overwritten if it is over `MaxBatchRPCCallsHardLimit`.

Builds on ethereum-optimism/optimism#3544.

* changeset

* fix lint

* fix test
ilyaluk pushed a commit to flashbots/proxyd that referenced this pull request Sep 4, 2025
* proxyd: Add batch size metric and configurable max

The max batch size will be overwritten if it is over `MaxBatchRPCCallsHardLimit`.

Builds on ethereum-optimism/optimism#3544.

* changeset

* fix lint

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants