Skip to content

chore: Disable PR commenting by codecov bot#3574

Merged
mergify[bot] merged 2 commits intodevelopfrom
disable-codecov-bot
Sep 27, 2022
Merged

chore: Disable PR commenting by codecov bot#3574
mergify[bot] merged 2 commits intodevelopfrom
disable-codecov-bot

Conversation

@maurelian
Copy link
Contributor

Description

Prevents the codecov bot from commenting on PRs. We may wish to enable this again later when the configuration is more mature.

@changeset-bot
Copy link

changeset-bot bot commented Sep 27, 2022

⚠️ No Changeset found

Latest commit: a3e11ce

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@maurelian maurelian requested review from mslipper, optimisticben and zhwrd and removed request for optimisticben September 27, 2022 13:09
@tynes
Copy link
Contributor

tynes commented Sep 27, 2022

Were the comments that were being added not very useful?

@tynes
Copy link
Contributor

tynes commented Sep 27, 2022

An example #3535 (comment)

@maurelian
Copy link
Contributor Author

Were the comments that were being added not very useful?

I don't think they're very useful yet. IMO there's going to be some observing and tweaking to be done in the codecov settings until we get it setup to be really valuable, so I don't want to irritate people with yet another bot until it's in a better state.

An example #3535 (comment)

That's a good example actually, as the comment was posted before we started ignoring the op-bindings module in coverage reports.

Generally, I think that a bot still implies a fairly manual process. Just failing in CI if coverage decreases would more strongly reinforce the habit of adding tests for new code.

Copy link
Contributor

@tynes tynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like bot comments eventually, but ok with disabling them until its set up nicely

Copy link
Contributor

@optimisticben optimisticben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt

@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit ace001d into develop Sep 27, 2022
@mergify mergify bot deleted the disable-codecov-bot branch September 27, 2022 15:03
@mergify mergify bot removed the on-merge-train label Sep 27, 2022
This was referenced Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants