Skip to content

fix(ctp): post-audit cleanup for the erc721 bridge#3549

Merged
mergify[bot] merged 3 commits intodevelopfrom
ctp/nft-fixes
Sep 26, 2022
Merged

fix(ctp): post-audit cleanup for the erc721 bridge#3549
mergify[bot] merged 3 commits intodevelopfrom
ctp/nft-fixes

Conversation

@sam-goldman
Copy link
Contributor

This PR:

  • Adds input validation for the ERC721Bridge constructor arguments (M-06 in the audit).
  • Fixes a single typo in the L1ERC721Bridge (N-09).
  • Removes the ERC721Refunded event declaration in the ERC721Bridge, which is no longer used as of this PR.

@changeset-bot
Copy link

changeset-bot bot commented Sep 23, 2022

🦋 Changeset detected

Latest commit: 4fdf12e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@eth-optimism/contracts-periphery Patch
@eth-optimism/drippie-mon Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 2-reviewers A-op-bindings Area: op-bindings labels Sep 23, 2022
@tynes
Copy link
Contributor

tynes commented Sep 25, 2022

What PR is the canonical source of truth for all audit fixes?

I'd like to double check myself that all are included

@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit d3fe9b6 into develop Sep 26, 2022
@mergify mergify bot deleted the ctp/nft-fixes branch September 26, 2022 02:26
@mergify mergify bot removed the on-merge-train label Sep 26, 2022
tynes added a commit that referenced this pull request Sep 26, 2022
tynes added a commit that referenced this pull request Sep 26, 2022
@sam-goldman
Copy link
Contributor Author

sam-goldman commented Sep 26, 2022

What PR is the canonical source of truth for all audit fixes?

Unfortunately there is no single canonical PR for the audit fixes. I'd say the closest thing is the original set of nine PRs that I made in the optimism-audit-fixes repo here. You can also check the diff of this mega PR which contains those nine PRs merged together. However, that PR has some minor mistakes from merge conflicts and hasn't been reviewed thoroughly, so I wouldn't call it canonical.

This was referenced Sep 29, 2022
tynes added a commit that referenced this pull request Oct 5, 2022
tynes added a commit that referenced this pull request Oct 5, 2022
Configures the ERC721 bridge

contracts-bedrock: port fixes

Ports fixes from #3549

contracts-bedrock: remove ownable upgradable

contracts-bedrock: more fixes

contracts-bedrock: start tests

contracts-bedrock: port predeploy fixes
tynes added a commit that referenced this pull request Oct 6, 2022
Configures the ERC721 bridge

contracts-bedrock: port fixes

Ports fixes from #3549

contracts-bedrock: remove ownable upgradable

contracts-bedrock: more fixes

contracts-bedrock: start tests

contracts-bedrock: port predeploy fixes
tynes added a commit that referenced this pull request Oct 19, 2022
Configures the ERC721 bridge

contracts-bedrock: port fixes

Ports fixes from #3549

contracts-bedrock: remove ownable upgradable

contracts-bedrock: more fixes

contracts-bedrock: start tests

contracts-bedrock: port predeploy fixes
tynes added a commit that referenced this pull request Oct 19, 2022
Configures the ERC721 bridge

contracts-bedrock: port fixes

Ports fixes from #3549

contracts-bedrock: remove ownable upgradable

contracts-bedrock: more fixes

contracts-bedrock: start tests

contracts-bedrock: port predeploy fixes
tynes added a commit that referenced this pull request Oct 20, 2022
Configures the ERC721 bridge

contracts-bedrock: port fixes

Ports fixes from #3549

contracts-bedrock: remove ownable upgradable

contracts-bedrock: more fixes

contracts-bedrock: start tests

contracts-bedrock: port predeploy fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-op-bindings Area: op-bindings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants