Skip to content

op-node: Cleanup calldata source API#3532

Merged
mergify[bot] merged 2 commits intodevelopfrom
jg/new_calldata_source
Sep 26, 2022
Merged

op-node: Cleanup calldata source API#3532
mergify[bot] merged 2 commits intodevelopfrom
jg/new_calldata_source

Conversation

@trianglesphere
Copy link
Contributor

@trianglesphere trianglesphere commented Sep 22, 2022 •
edited
Loading

Description

This provides a new set of objects which provide the following API guarantees:

  • The opening of a data for a new L1 block will never fail.
  • If it failed to get transactions, it does so in the calls to Next.

This greatly simplifies usage of this object when constructing new data. If the node did not keep track of the internal state, the external users of this API would have to keep track of this state in a more complex way.

Tests

Please describe any tests you've added. If you've added no tests, or left important behavior untested, please explain why not.

Additional context

Add any other context about the problem you're solving.

Metadata

  • Fixes ENG-2746

@mergify
Copy link
Contributor

mergify bot commented Sep 22, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@changeset-bot
Copy link

changeset-bot bot commented Sep 22, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8e611a0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@trianglesphere trianglesphere mentioned this pull request Sep 22, 2022
Closed
@trianglesphere trianglesphere force-pushed the jg/new_calldata_source branch 3 times, most recently from d158635 to d56423a Compare September 23, 2022 20:12
@trianglesphere trianglesphere marked this pull request as ready for review September 23, 2022 20:30
protolambda
protolambda reviewed Sep 26, 2022
View reviewed changes
Copy link
Contributor

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please rename the interface in the retrieval stage back

@trianglesphere
op-node: Cleanup calldata source API
d1b6da8 
This provides a new set of objects which provide the following API guarantees:
- The opening of a data for a new L1 block will never.
- If it failed to get transactions, it does so in the calls to `Next`.

This greatly simplifies usage of this object when constructing new data. If
the node did not keep track of the internal state, the external users of this
API would have to keep track of this state in a more complex way.
@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit 53fbf91 into develop Sep 26, 2022
@mergify mergify bot deleted the jg/new_calldata_source branch September 26, 2022 20:55
@mergify mergify bot removed the on-merge-train label Sep 26, 2022
This was referenced Sep 29, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@mslipper mslipper mslipper approved these changes

@protolambda protolambda protolambda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@trianglesphere @mslipper @protolambda