contracts-periphery: remove ownable upgradable from erc721 factory#3541
Merged
mergify[bot] merged 3 commits intodevelopfrom Sep 23, 2022
Merged
contracts-periphery: remove ownable upgradable from erc721 factory#3541mergify[bot] merged 3 commits intodevelopfrom
mergify[bot] merged 3 commits intodevelopfrom
Conversation
The ownable upgradable modifier was not used anywhere in the contract. The erc20 factory does not follow that pattern. This change simplifies things by moving values to immutables instead of being in storage. This is a cleanup PR before migrating these contracts to `contracts-bedrock`.
🦋 Changeset detectedLatest commit: 0de41c6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The ownable upgradable modifier was not used anywhere in the contract. The erc20 factory does not follow that pattern. This change simplifies things by moving
values to immutables instead of being in storage.
This is a cleanup PR before migrating these contracts to
contracts-bedrock.