op-e2e: e2eutils package for new action testing setup#3586
op-e2e: e2eutils package for new action testing setup#3586mergify[bot] merged 1 commit intodevelopfrom
Conversation
|
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
protolambda
force-pushed
the
action-tests-setup
branch
from
43075f2 to
96c21ec
Compare
tynes
left a comment
tynes
left a comment
There was a problem hiding this comment.
Looks good to me, good work. Being able to run tests against the genesis creation code on L2 is going to be amazing
mslipper
left a comment
mslipper
left a comment
There was a problem hiding this comment.
This is great, thanks Proto. We can use a bunch of these in Hive too.
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
trianglesphere
left a comment
trianglesphere
left a comment
There was a problem hiding this comment.
Really nice work. I really like all the comments
| return jwtPath | ||
| } | ||
|
|
||
| func uint642big(in uint64) *hexutil.Big { |
There was a problem hiding this comment.
uint64ToBig is a more go-like name. The 642 is also a little hard to parse.
4 participants
Description
I wrote the first iteration of these utils as part of the Hive testing, but then ported it over to use more of the chainops code from Mark and use it in the experimental action testing branch. Now the utils are in a separate package, so we can share them with op-e2e long term.
Action-testing itself will be a sub-package of the op-e2e module, and import these test utils.
Tests
Includes some basic tests to make sure the test setup itself behaves like expected.
Additional context
This test setup code can later also be used by op-e2e.
Metadata
Fix ENG-2836