Skip to content

fix(ct): bug in L2OutputOracle constructor#3322

Merged
mergify[bot] merged 4 commits intodevelopfrom
sc/ct-l2oo-bug
Sep 23, 2022
Merged

fix(ct): bug in L2OutputOracle constructor#3322
mergify[bot] merged 4 commits intodevelopfrom
sc/ct-l2oo-bug

Conversation

@smartcontracts
Copy link
Contributor

@smartcontracts smartcontracts commented Aug 26, 2022

Description
Fixes a small bug in the L2OutputOracle constructor where an assertion
was being made about the wrong value. Unlikely that this would've caused
any significant issues but worth fixing anyway.

@changeset-bot
Copy link

changeset-bot bot commented Aug 26, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: e8b54e4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@eth-optimism/contracts-bedrock Patch
@eth-optimism/actor-tests Patch
@eth-optimism/sdk Patch
@eth-optimism/drippie-mon Patch
@eth-optimism/message-relayer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@smartcontracts smartcontracts marked this pull request as ready for review August 26, 2022 17:25
@github-actions github-actions bot added 2-reviewers A-pkg-contracts-bedrock Area: packages/contracts-bedrock labels Aug 26, 2022
@maurelian
Copy link
Contributor

maurelian commented Aug 26, 2022

I approve this, but now that I think about it we really need to have the discipline of writing a test every time we fix a bug. even when it's a trivial one like this. would really appreciate if you'd be so kind as to oblige me on that.

@smartcontracts
Copy link
Contributor Author

smartcontracts commented Aug 26, 2022

SGTM!

@smartcontracts smartcontracts force-pushed the sc/ct-l2oo-bug branch 2 times, most recently from 3d46bdd to 80a7c79 Compare August 26, 2022 18:40
@smartcontracts
Copy link
Contributor Author

smartcontracts commented Aug 26, 2022

I approve this, but now that I think about it we really need to have the discipline of writing a test every time we fix a bug. even when it's a trivial one like this. would really appreciate if you'd be so kind as to oblige me on that.

Done

@mslipper
Copy link
Contributor

mslipper commented Sep 7, 2022

@smartcontracts mind updating the gas snapshot + bindings?

@mergify
Copy link
Contributor

mergify bot commented Sep 10, 2022

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Sep 10, 2022
@mergify mergify bot removed the conflict label Sep 10, 2022
@mergify
Copy link
Contributor

mergify bot commented Sep 10, 2022

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Sep 10, 2022
@mergify mergify bot removed the conflict label Sep 10, 2022
@tynes
Copy link
Contributor

tynes commented Sep 10, 2022

This needs code to handle the L1 genesis creation

@mergify
Copy link
Contributor

mergify bot commented Sep 10, 2022

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Sep 10, 2022
@mergify mergify bot removed the conflict label Sep 11, 2022
@mergify
Copy link
Contributor

mergify bot commented Sep 12, 2022

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

@mergify
Copy link
Contributor

mergify bot commented Sep 19, 2022

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Sep 19, 2022
@mslipper
Copy link
Contributor

mslipper commented Sep 19, 2022 •
edited
Loading

This is breaking tests because the Geth simulated backend that deploys the contracts on L1 in the devnet sets the block timestamp to zero. We can fix this, but it'll require changes in op-geth to allow you to specify the block timestamp in the simulator.

@mslipper mslipper mentioned this pull request Sep 21, 2022
Merged
mslipper added a commit that referenced this pull request Sep 21, 2022
@mslipper
chore: Update op-geth to latest version
de40990 
Update op-geth to the latest version on the `optimism-history` branch. This version exposes the customizable simulator backend that we need to merge #3322.
@mslipper mslipper mentioned this pull request Sep 21, 2022
Merged
mslipper added a commit that referenced this pull request Sep 21, 2022
@mslipper
chore: Update op-geth to latest version
9f3a23e 
Update op-geth to the latest version on the `optimism-history` branch. This version exposes the customizable simulator backend that we need to merge #3322.
mslipper added a commit that referenced this pull request Sep 21, 2022
@mslipper
chore: Update op-geth to latest version
f1b33dc 
Update op-geth to the latest version on the `optimism-history` branch. This version exposes the customizable simulator backend that we need to merge #3322.
mslipper added a commit that referenced this pull request Sep 22, 2022
@mslipper
chore: Update op-geth to latest version
cbc6c03 
Update op-geth to the latest version on the `optimism-history` branch. This version exposes the customizable simulator backend that we need to merge #3322.
mslipper added a commit that referenced this pull request Sep 22, 2022
@mslipper
chore: Update op-geth to latest version
34bea93 
Update op-geth to the latest version on the `optimism-history` branch. This version exposes the customizable simulator backend that we need to merge #3322.
mslipper added a commit that referenced this pull request Sep 22, 2022
@mslipper
chore: Update op-geth to latest version
165841a 
Update op-geth to the latest version on the `optimism-history` branch. This version exposes the customizable simulator backend that we need to merge #3322.
mergify bot added a commit that referenced this pull request Sep 22, 2022
@mslipper @mergify
chore: Update op-geth to latest version (#3524)
1bbce92 
Update op-geth to the latest version on the `optimism-history` branch. This version exposes the customizable simulator backend that we need to merge #3322.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@mergify mergify bot removed the conflict label Sep 22, 2022
@smartcontracts @mslipper
fix(ct): bug in L2OutputOracle constructor
e937d4a 
Fixes a small bug in the L2OutputOracle constructor where an assertion
was being made about the wrong value. Unlikely that this would've caused
any significant issues but worth fixing anyway.
@mslipper
Update l1genesis generation code
11a8821 
Puts the genesis timestamp inside the simulator, and updates the simulator code to properly wait for blocks to be mined. See the comments in deployer.go and layer_one.go.
@mergify
Copy link
Contributor

mergify bot commented Sep 23, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Sep 23, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Sep 23, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit 6ed68fa into develop Sep 23, 2022
@mergify mergify bot deleted the sc/ct-l2oo-bug branch September 23, 2022 17:22
@mergify mergify bot removed the on-merge-train label Sep 23, 2022
This was referenced Sep 29, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tynes tynes tynes approved these changes

@maurelian maurelian maurelian approved these changes

+1 more reviewer

@mslipper mslipper mslipper approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-pkg-contracts-bedrock Area: packages/contracts-bedrock

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@smartcontracts @maurelian @mslipper @tynes