Merged
Conversation
Fixes OPB-10: No Checks for Deposit Transaction Type When Calling `L1InfoDepositTxData()`. This PR adds a check in `blockToBatch` that checks the type of the first transaction in the block, and returns an error if it isn't a deposit transaction.
|
Contributor
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
trianglesphere
approved these changes
Sep 23, 2022
tynes
approved these changes
Sep 24, 2022
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes OPB-10: No Checks for Deposit Transaction Type When Calling
L1InfoDepositTxData(). This PR adds a check inblockToBatchthat checks the type of the first transaction in the block, and returns an error if it isn't a deposit transaction.Fixes ENG-2623.