Skip to content

fix(dtl): consistency checks for L1 sync#3356

Merged
mergify[bot] merged 2 commits intodevelopfrom
sc/dtl-fix-l1-sync-consistency
Sep 26, 2022
Merged

fix(dtl): consistency checks for L1 sync#3356
mergify[bot] merged 2 commits intodevelopfrom
sc/dtl-fix-l1-sync-consistency

Conversation

@smartcontracts
Copy link
Contributor

Description
Adds consistency checks for L1 syncing nodes in the DTL. One of my personal nodes seemed to halt with this error, so fixing it.

@changeset-bot
Copy link

changeset-bot bot commented Sep 8, 2022

🦋 Changeset detected

Latest commit: d17bbcd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/data-transport-layer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 2-reviewers C-protocol-critical Category: Modifies protocol-critical code labels Sep 8, 2022
@mergify mergify bot requested a review from tynes September 8, 2022 12:03
@smartcontracts
Copy link
Contributor Author

I'm syncing a mainnet node with this change

Adds consistency checks for L1 syncing nodes in the DTL. One of my
personal nodes seemed to halt with this error, so fixing it.
@smartcontracts smartcontracts force-pushed the sc/dtl-fix-l1-sync-consistency branch from 25c04ff to c877eaa Compare September 19, 2022 19:28
@mslipper
Copy link
Contributor

Converting to draft - let me know once sync completes and we can move to review again.

@mslipper mslipper marked this pull request as draft September 22, 2022 02:27
@smartcontracts smartcontracts marked this pull request as ready for review September 24, 2022 06:17
@smartcontracts
Copy link
Contributor Author

This PR synced properly on mainnet. Marking ready for review.

@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit 81c1cd9 into develop Sep 26, 2022
@mergify mergify bot deleted the sc/dtl-fix-l1-sync-consistency branch September 26, 2022 18:19
@mergify mergify bot removed the on-merge-train label Sep 26, 2022
This was referenced Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-protocol-critical Category: Modifies protocol-critical code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants