Skip to content

contracts-bedrock: fuzz L2ToL1MessagePasser#3527

Merged
mergify[bot] merged 5 commits intodevelopfrom
ctb/fuzz-message-passer-storage-slot
Sep 27, 2022
Merged

contracts-bedrock: fuzz L2ToL1MessagePasser#3527
mergify[bot] merged 5 commits intodevelopfrom
ctb/fuzz-message-passer-storage-slot

Conversation

@tynes
Copy link
Contributor

@tynes tynes commented Sep 22, 2022

Description

Fuzzes the L2ToL1MessagePasser for state changes to its storage. This specifically tests that the storage slot that the proofs are generated against is computed correctly. This is important to test as any changes that break the proof would also break this test.

The fuzz runs were used to generate test cases in
#3469 for off chain computation of the storage slots for withdrawals.

@changeset-bot
Copy link

changeset-bot bot commented Sep 22, 2022

🦋 Changeset detected

Latest commit: cbcf5ea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@eth-optimism/contracts-bedrock Patch
@eth-optimism/actor-tests Patch
@eth-optimism/sdk Patch
@eth-optimism/drippie-mon Patch
@eth-optimism/message-relayer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 2-reviewers A-pkg-contracts-bedrock Area: packages/contracts-bedrock labels Sep 22, 2022
@mergify
Copy link
Contributor

mergify bot commented Sep 22, 2022

Hey @tynes! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Sep 22, 2022
@tynes tynes force-pushed the ctb/fuzz-message-passer-storage-slot branch from 6a22b58 to 12e8b69 Compare September 22, 2022 13:49
@mergify mergify bot removed the conflict label Sep 22, 2022
@mergify
Copy link
Contributor

mergify bot commented Sep 22, 2022

Hey @tynes! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added conflict and removed conflict labels Sep 22, 2022
@mergify
Copy link
Contributor

mergify bot commented Sep 23, 2022

Hey @tynes! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Sep 23, 2022
@tynes tynes force-pushed the ctb/fuzz-message-passer-storage-slot branch from 12e8b69 to 74154b2 Compare September 25, 2022 20:26
@mergify mergify bot removed the conflict label Sep 25, 2022
@tynes
Copy link
Contributor Author

tynes commented Sep 25, 2022

I've resolved the merge conflict, this should be good to review @smartcontracts

@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2022

Hey @tynes! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Sep 26, 2022
@tynes tynes force-pushed the ctb/fuzz-message-passer-storage-slot branch from 9759262 to fe0ad25 Compare September 26, 2022 22:03
@mergify mergify bot removed the conflict label Sep 26, 2022
@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2022

Hey @tynes! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Sep 26, 2022
Fuzzes the L2ToL1MessagePasser for state changes to its storage.
This specifically tests that the storage slot that the proofs
are generated against is computed correctly. This is important to
test as any changes that break the proof would also break this test.

The fuzz runs were used to generate test cases in
#3469
for off chain computation of the storage slots for withdrawals.
@tynes tynes force-pushed the ctb/fuzz-message-passer-storage-slot branch from fe0ad25 to 9c98f73 Compare September 26, 2022 22:30
@mergify mergify bot removed the conflict label Sep 26, 2022
@tynes
Copy link
Contributor Author

tynes commented Sep 27, 2022

Can I get a review on this @smartcontracts ?

@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Sep 27, 2022
@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2022

Merge failed. Please see automated check logs for more details.

@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot merged commit a6cbfee into develop Sep 27, 2022
@mergify mergify bot deleted the ctb/fuzz-message-passer-storage-slot branch September 27, 2022 18:04
@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Sep 27, 2022
This was referenced Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-pkg-contracts-bedrock Area: packages/contracts-bedrock

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants