Skip to content

op-node: Switch attributes queue to be pull based#3598

Merged
mergify[bot] merged 1 commit intojg/batchqueuefrom
jg/attributesqueue
Sep 28, 2022
Merged

op-node: Switch attributes queue to be pull based#3598
mergify[bot] merged 1 commit intojg/batchqueuefrom
jg/attributesqueue

Conversation

@trianglesphere
Copy link
Contributor

@trianglesphere trianglesphere commented Sep 28, 2022

Description

The progress API is very nearly removed from the engine queue stage.

Metadata

  • Fixes ENG-2751

@changeset-bot
Copy link

changeset-bot bot commented Sep 28, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: dd57ff2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@trianglesphere trianglesphere marked this pull request as ready for review September 28, 2022 21:27
protolambda
protolambda approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One nit about an error case we may want to adjust

@trianglesphere
op-node: Switch attributes queue to be pull based
dd57ff2 
The progress API is very nearly removed from the engine queue stage.
@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot merged commit 102a9c2 into jg/batchqueue Sep 28, 2022
@mergify mergify bot deleted the jg/attributesqueue branch September 28, 2022 22:52
@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Sep 28, 2022
This was referenced Sep 29, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@mslipper mslipper mslipper approved these changes

@protolambda protolambda protolambda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@trianglesphere @mslipper @protolambda