Skip to content

ctp: fixup deploy scripts for the nft bridge#3570

Merged
mergify[bot] merged 8 commits intodevelopfrom
fix/deploy-scripts
Sep 28, 2022
Merged

ctp: fixup deploy scripts for the nft bridge#3570
mergify[bot] merged 8 commits intodevelopfrom
fix/deploy-scripts

Conversation

@tynes
Copy link
Contributor

@tynes tynes commented Sep 26, 2022

Description

The most important one is the deploy script for the Proxy that will end up at the predeploy on L2. There are specific checks for the correct deployer account being used. Will likely require some changes to the hardhat config when doing the actual deployment.

@changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 501a280

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@github-actions github-actions bot added 2-reviewers A-op-bindings Area: op-bindings labels Sep 26, 2022
@tynes
Copy link
Contributor Author

tynes commented Sep 27, 2022

Going to be testing this against ops

@tynes tynes force-pushed the fix/deploy-scripts branch from 1e69dfa to 0088ec6 Compare September 27, 2022 13:46
@tynes
Copy link
Contributor Author

tynes commented Sep 27, 2022

Tagging do-not-merge until i have it e2e working with ops

@tynes tynes mentioned this pull request Sep 27, 2022
Merged
smartcontracts
smartcontracts reviewed Sep 27, 2022
View reviewed changes
@tynes tynes force-pushed the fix/deploy-scripts branch from bb2bc39 to e3ce648 Compare September 28, 2022 16:08
tynes
tynes commented Sep 28, 2022
View reviewed changes
smartcontracts
smartcontracts approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@smartcontracts smartcontracts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I'm reasonably happy with this. We can clean it up later once we move it into predeploys.

@tynes
ctp: fixup deploy scripts for the nft bridge
45914f6 
The most important one is the deploy script for the
`Proxy` that will end up at the predeploy on L2. There
are specific checks for the correct deployer account
being used. Will likely require some changes to the
hardhat config when doing the actual deployment.
@tynes
ctp: update deploy scripts
b9959f0
@tynes
ctp: update deploy scripts
f8f8c55
@tynes
ctp: move away from deterministic deployments
f61aca8
@tynes
op: deployments
ea330c3
@tynes
fixes
541f5aa
@tynes
deploy-script: refactor
0bda78b
@tynes
deploy: comments
501a280
@tynes tynes force-pushed the fix/deploy-scripts branch from aa003b4 to 501a280 Compare September 28, 2022 20:00
@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot merged commit cfec034 into develop Sep 28, 2022
@mergify mergify bot deleted the fix/deploy-scripts branch September 28, 2022 20:56
@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Sep 28, 2022
This was referenced Sep 29, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smartcontracts smartcontracts smartcontracts approved these changes

@maurelian maurelian maurelian approved these changes

+1 more reviewer

@semgrep-app semgrep-app[bot] semgrep-app[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-op-bindings Area: op-bindings

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tynes @smartcontracts @maurelian