chore: mergeback_chore-release_8.4.0 into edge by ahiuchingau · Pull Request #18012 · Opentrons/opentrons

ahiuchingau · 2025-04-08T20:14:11Z

Overview

Merging the latest chore_release-8.4.0 back to edge.
Plus adding a fix for command schema 13 that was not available for the chore_release-8.4.0 branch.

There were several merge conflicts but most were straightforward. Here are the one that i could use some extra 👀 on:

api/tests/opentrons/protocol_api/test_instrument_context.py

It's possible for users to perform LPC on the Flex without a tiprack in the protocol, and we should, you know, let users LPC, since that's really just an OT-2 restriction. A minor CSS fix is included here too for the OT-2 wizard header.

…p dispensing (#17851) We count every single evotips_dispense that happens on a pipette and store it in the eeprom. We report it when you connect the pipette, and we can add more structured data from it if you want.

Closes RQA-3980 # Overview Updates all liquid classes' multi-dispense blowout entries to: - specify blowout location of `trash` - specify blowout flow rate to be the same as the single dispense flow rate specified for that pipette+tip combo - enable blowout ## Risk assessment Low. Just enables a setting that was disabled by default. We already have tests that check that transfers happen correctly when these properties are enabled

…7894) Closes RQA-4010 Currently, LPC utilizes the existing labware definitions from runs/:runId/loaded_labware_defintions and POSTs those definitions to the LPC maintenance run. However, it turns out that those definitions do not necessarily exist on the run resource at the time of LPC maintenance run creation. We actually have access to the labware definitions from analysis directly and don't need to query the server for them. A much simpler (and functional) approach is to just POST the definitions we already have.

…zero not error (#17909) (copy of other PR 17877 that was merged into edge earlier) As written before, the _find_volume_in_partial_frustum function would raise an error if the target_height equaled the top or bottom of any frustum. For example, 0.0 in my case, because I was getting this error during my protocol run: opentrons.protocol_engine.errors.exceptions.InvalidLiquidHeightFound: Error 4000 GENERAL_ERROR (InvalidLiquidHeightFound): Unable to find volume at given well-height 0.0.

Update the labware definitions for the evotip adapters. These are the existing geometry for the 4 v2 adapters; they're getting new names (and thus going to v1), and they're getting their branding details filled in. We've removed the v1 adapters entirely, since their names were confusingly close to the new ones. This also adds the adapters to the labware tab and to the labware library. Note that it does _not_ add them to PD; PD can't create evotip protocols, and anyway we only want people to be using these with one specific protocol. Closes EXEC-1378 Closes EXEC-1364

…17901) Closes RQA-4012 Fixes an issue applying offsets when the offsetLocationSequence involves a module. The util that converts the locationSequence to an offsetLocationSequence assumed that the ordering of the sequence should translate 1:1, but for offsetLocationSequence, the addressableArea kind component must be last in order to successfully POST updates for the offset.

) Closes EXEC-1360 Adds the scoped LPC Redesign functionality for the OT-2: Skipping! You can now choose not to LPC a tip rack or a labware. You still can't skip the "attach tip" and "detach tip" step for obvious reasons, though. Applying offsets after each step! Yes, exiting LPC early means you do get to keep the offset data that you set or previously existed.

# Overview  Release notes for 8.4.0-alpha. ## Test Plan and Hands on Testing  ## Changelog  Added new features, improvements, and bug fixed (including [8.3.0 punted bugs](https://opentrons.atlassian.net/browse/RQA-3897)) ## Review requests  -any changes to liquid classes customer messaging? -any missing bug fixes or improvements? ## Risk assessment  low.

Closes RQA-4014 On the ODD during LPC, on the Labware List view, if you click anything but the first labware, you will still select the first labware in the list. This PR makes it so when you click on not the first labware, you get the labware you actually selected.

loses RQA-4013 There are a couple pieces of LPC state that are not necessarily controlled by the active app: the deck config and the labware info (which contains offset data). I recently moved the logic for updating store changes whenever the deck config changed to a separate hook, but I didn't do the same for the labware info, woops. This means that if a diferent user was actively performing LPC, offset updates wouldn't reflect in protocol setup offset table. This commit creates granular state update actions for both the deck config and labware info.

…an adapter (#17918) Closes EXEC-1390 Certain labware should always be LPC'd in an adapter, even when setting a default offset (eg, evotips). To determine whether or not we require an adapter for all offset calculations, we examine the stackingOnly quirk present on the labware definition, and add the necessary info to the default offset.

## Overview This refactors the desktop app and ODD components for doing a device reset. Goes towards EXEC-1281. ## Background Historically, all of the reset options were server-defined. The client would fetch the available options from the server (via `GET /settings/reset/options`) and display them as-is, with server-defined text. More recently, that model has been stretched beyond its limits: * We want the UI to be localized with frontend-defined strings. * We want frontend to control the options' ordering and grouping. * We want some reset options, like `onDeviceDisplay`, to be special: they should be hidden from the UI and selected implicitly depending on the user's selection of other options. * We want the server to implement some of these reset options through separate endpoints, instead of all of them through `/settings/reset`. (See e.g. [this discussion](#17051 (comment)), though I sometimes have second thoughts about this.) So we have been in a weird in-between where we were getting the dynamic list of options from the server, but still making strong assumptions about what that list would contain. This PR rewrites it to be fully client-decided. ## Changelog This is intended to not have any user-facing change. The one "accidental" change that I'm aware of is that if the client is newer than the server and has an extra reset option, it will now be displayed, and filtered out of the HTTP request. Formerly, it would not even be displayed.

# Overview Realized a few wrong values in my previous PR #17895. The multi-disp blowout flow rates are supposed to be the max of the single dispense flow rates for that pipette+tiprack. A couple of entries got min values instead. Fixed those ## Risk assessment Low. Small fixes in definitions

Closes AUTH-1496 # Overview Implements the tip returning functionality to `distribute_liquid`. ## Risk assessment Medium-Low. Affects `distribute_liquid` tip handling, but has decent test coverage to avoid accidental behavior changes.

…comodate lid stacking (#17896) Fix EXEC-1220, EXEC-1223, EXEC-1303, EXEC-1304, EXEC-1305, EXEC-1092

…17900) adds multi-channel pipette support to the liquid class transfer methods (`transfer_liquid`, `distribute_liquid`, `consolidate_liquid`) by means of adding well grouping logic for multi-tip configurations addressing 96 and 384 well plates.

Closes RQA-4016 Believe it or not, we shouldn't LPC in staging area slots. To fix, we just need to mark LPC-able commands as being "not valid" if they are in a staging slot addressable area.

What it says on the tin, removes the tiprack lid labware from the blocklist. You don't buy this on its own so it doesn't have branding details and a sku.

Closes EXEC-1392 and RQA-4018

We should add a prepare-to-aspirate to the python protocol api `air_gap` command, where it can issue the command after we've moved to a known-dry position and before we actually dispense the airgap command. We know the position is dry and therefore it's safe to do a prepare. However, to be able to _unconditionally_ do a prepare, we also need to add a fix to the engine prepare command to no-op if the pipette is already prepared to aspirate. This is pretty important because if we've already aspirated some liquid, we really don't want to move back to the bottom position and dispense it all. Useful testing protocol: ``` from opentrons.protocol_api import ProtocolContext metadata = {"protocolName": "Test air gap prepare"} requirements = {"apiLevel": "2.22", "robotType": "Flex"} def run(protocol: ProtocolContext) -> None: plate = protocol.load_labware("biorad_384_wellplate_50ul", "A1") rack = protocol.load_labware("opentrons_flex_96_tiprack_50ul", "A2") pipette = protocol.load_instrument("flex_1channel_50", "left", tip_racks=[rack]) pipette.pick_up_tip() pipette.aspirate(location=plate["A1"].bottom(z=2), volume=10) pipette.dispense(location=plate["A1"].top(), volume=10) pipette.blow_out(location=plate["A1"].top()) pipette.air_gap(height=5, volume=10) pipette.dispense(location=plate["A2"].top(), volume=10) pipette.return_tip() ``` Closes EXEC-1391

These numbers can't be the same between press fit and cam action. Whoops!

Usages were failing if the node wasn't listed. I think this happens because we do the usage request sometimes before we've registered all the nodes but I'm not sure, so let's at least get rid of the exception and add some logs to help figure out the context.

Closes RQA-4022 The "apply offsets" button disabled status utilized different state than the copy that would render the "offsets applied/not applied". These should be the same. More importantly, on the desktop, if a different user applied offsets, the missingSteps would not filter out LPC, since it was directly tied to a CTA. Additionally, after talking to Design/QA, we've decided that when applying offsets, the "launch LPC" button should be disabled, too.

…T /labwareOffsets` (#17952)

Closes RQA-4017 and RQA-4011 On the physical ODD, it's possible queue jog commands in such a way that jog commands execute indefinitely. This issue was caused by using React async state updates to trigger queue processing. This PR rewrites the code to use refs for avoiding React asynchronous state updates, and also use Lodash's lovely debounce util, helping to improve the control flow.

… map (#17950) fix RQA-4025

Guess we missed these

codecov · 2025-04-08T20:17:34Z

Codecov Report

Attention: Patch coverage is 0% with 418 lines in your changes missing coverage. Please review.

Project coverage is 61.69%. Comparing base (94c8ede) to head (1cfc194).
Report is 3 commits behind head on edge.

Files with missing lines	Patch %	Lines
...educer/transforms/lpc/handleApplyWorkingOffsets.ts	0.00%	103 Missing ⚠️
...PositionCheck/hooks/useLPCCommands/useHandleJog.ts	0.00%	81 Missing ⚠️
...Flows/hooks/useMonitorMaintenanceRunForDeletion.ts	0.00%	36 Missing ⚠️
...EditOffset/PrepareLabware/PlaceItemInstruction.tsx	0.00%	34 Missing ⚠️
app/src/organisms/LabwareOffsetsTable/index.tsx	0.00%	27 Missing ⚠️
...heck/hooks/useLPCCommands/useSaveWorkingOffsets.ts	0.00%	23 Missing ⚠️
...arePositionCheck/FlexSetupLPC/LPCSetupFlexBtns.tsx	0.00%	15 Missing ⚠️
app/src/resources/runs/useCloneRun.ts	0.00%	13 Missing ⚠️
...vices/ProtocolRun/SetupLabware/LabwareListItem.tsx	0.00%	9 Missing ⚠️
...s/Desktop/Devices/ProtocolRun/ProtocolRunSetup.tsx	0.00%	8 Missing ⚠️
... and 23 more

Additional details and impacted files

@@            Coverage Diff             @@
##             edge   #18012      +/-   ##
==========================================
- Coverage   61.75%   61.69%   -0.07%     
==========================================
  Files        2967     2968       +1     
  Lines      229248   229422     +174     
  Branches    19488    19484       -4     
==========================================
- Hits       141575   141544      -31     
- Misses      87496    87701     +205     
  Partials      177      177

Flag	Coverage Δ
protocol-designer	`18.79% <0.00%> (-0.02%)`	⬇️
step-generation	`4.40% <0.00%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...nisms/LabwarePositionCheck/LPCFlows/useLPCFlows.ts	`1.35% <ø> (-0.29%)`	⬇️
...ionCheck/hooks/useLPCCommands/useHandleStartLPC.ts	`1.86% <ø> (ø)`
app/src/redux/protocol-runs/types/lpc/actions.ts	`100.00% <ø> (ø)`
app/src/redux/protocol-runs/types/lpc/offsets.ts	`100.00% <ø> (ø)`
...nHeaderModalContainer/hooks/useRunHeaderDropTip.ts	`1.92% <0.00%> (-0.02%)`	⬇️
...es/ProtocolRun/SetupLabware/OffDeckLabwareList.tsx	`90.90% <0.00%> (-3.04%)`	⬇️
...rotocolRun/SetupModuleAndDeck/SetupModulesList.tsx	`79.10% <0.00%> (-0.28%)`	⬇️
.../organisms/LabwareOffsetsTable/AccordionHeader.tsx	`27.27% <0.00%> (-0.86%)`	⬇️
...nisms/LabwarePositionCheck/LPCFlows/hooks/index.ts	`87.50% <0.00%> (-12.50%)`	⬇️
...itionCheck/LPCFlows/hooks/useInitLPCStore/index.ts	`3.77% <0.00%> (ø)`
... and 27 more

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

# Overview Adding methods like `transfer_with_liquid_class()` to the API reference. Addresses RTC-610. Any follow-up edits to these docstrings can be handled in #17992. ## Test Plan and Hands on Testing [Sandbox](http://sandbox.docs.opentrons.com/api-ref-liquid-classes/v2/new_protocol_api.html) ## Changelog - Param descriptions for the three main liquid class methods. - Unhide the methods - Add `LiquidClass` to the ref. - Nitpicks to allow docs to build. ## Review requests Are these "good enough"? Want to get these merged to keep other liquid class docs work moving. ## Risk assessment low, docs

jerader

thanks!

SyntaxColoring

test_instrument_context.py LGTM. Thanks!

Merging the latest chore_release-8.4.0 back to edge. Plus adding a fix for command schema 13 that was not available for release branch. --------- Co-authored-by: Josh McVey <josh.mcvey@opentrons.com> Co-authored-by: Jamey Huffnagle <jamey.huffnagle@opentrons.com> Co-authored-by: Ryan Howard <ryan.howard@opentrons.com> Co-authored-by: Sanniti Pimpley <sanni-t@users.noreply.github.com> Co-authored-by: Andy Sigler <andrewsigler1@gmail.com> Co-authored-by: Seth Foster <seth@opentrons.com> Co-authored-by: emilyburghardt <emily.burghardt@opentrons.com> Co-authored-by: Max Marrone <max@opentrons.com> Co-authored-by: Sarah Breen <sarah.breen@opentrons.com> Co-authored-by: Jeremy Leon <jeremy.leon@opentrons.com> Co-authored-by: Jethary Alcid <66035149+jerader@users.noreply.github.com> Co-authored-by: TamarZanzouri <zanzouritamar@gmail.com> Co-authored-by: Ed Cormany <edward.cormany@opentrons.com> Co-authored-by: Caila Marashaj <98041399+caila-marashaj@users.noreply.github.com> (cherry picked from commit 3692478)

y3rsh and others added 30 commits March 25, 2025 17:56

test(api): liquid classes blowout properties (#17875)

abc6bfb

feat(app): Refactor labware details into labware & liquid details, ac…

8b5d76a

…comodate lid stacking (#17896) Fix EXEC-1220, EXEC-1223, EXEC-1303, EXEC-1304, EXEC-1305, EXEC-1092

fix(app): Do not LPC in staging area slots (#17926)

6e68ce2

Closes RQA-4016 Believe it or not, we shouldn't LPC in staging area slots. To fix, we just need to mark LPC-able commands as being "not valid" if they are in a staging slot addressable area.

chore(shared-data): show tiprack lid in LL (#17925)

e121992

What it says on the tin, removes the tiprack lid labware from the blocklist. You don't buy this on its own so it doesn't have branding details and a sku.

feat(app): Add default offset info banner to LPC (#17923)

b0d9f72

Closes EXEC-1392 and RQA-4018

feat(app): Add an option to clear labware offsets (#17929)

6187fb3

fix(api): make the 8-channel evo pickup work (#17930)

a84f4e1

These numbers can't be the same between press fit and cam action. Whoops!

perf(robot-server): Optimize adding many offsets at once through `POS…

c0c9894

…T /labwareOffsets` (#17952)

fix(app): remove display of offset vector in labware overlay on setup…

0bf9489

… map (#17950) fix RQA-4025

chore: hardware CI workflows to 24.04 (#17956)

5f4bcc0

Guess we missed these

ahiuchingau and others added 10 commits April 8, 2025 16:52

oops

cfdf10b

fix lint

91916fd

Merge branch 'edge' into mergeback_release-8.4.0

01d942f

chore(locize): sync translations (#18009)

7b9af5d

chore(locize): sync for translations needed (#18009)

c0ae03e

fix(api): make error message clearer for lld issues (#18005)

bcb87f6

re-merge

c796d7b

fixup! re-merge

388399a

Merge branch 'edge' into mergeback_release-8.4.0

1cfc194

jerader approved these changes Apr 9, 2025

View reviewed changes

SyntaxColoring approved these changes Apr 9, 2025

View reviewed changes

ahiuchingau merged commit 3692478 into edge Apr 9, 2025
83 of 84 checks passed

ahiuchingau deleted the mergeback_release-8.4.0 branch April 9, 2025 19:46

ddcc4 mentioned this pull request May 17, 2025

Candidate chore_release-8.5.0 cherry-pick branch #18379

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: mergeback_chore-release_8.4.0 into edge#18012

chore: mergeback_chore-release_8.4.0 into edge#18012
ahiuchingau merged 64 commits intoedgefrom
mergeback_release-8.4.0

ahiuchingau commented Apr 8, 2025 •

edited

Loading

Uh oh!

codecov Bot commented Apr 8, 2025 •

edited

Loading

Uh oh!

jerader left a comment

Uh oh!

SyntaxColoring left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

Conversation

ahiuchingau commented Apr 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Uh oh!

codecov Bot commented Apr 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jerader left a comment

Choose a reason for hiding this comment

Uh oh!

SyntaxColoring left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

ahiuchingau commented Apr 8, 2025 •

edited

Loading

codecov Bot commented Apr 8, 2025 •

edited

Loading