Skip to content

chore(api,shared-data): update evotip definitions#17907

Merged
sfoster1 merged 7 commits intochore_release-8.4.0from
exec-1378-update-evotip-names
Mar 27, 2025
Merged

chore(api,shared-data): update evotip definitions#17907
sfoster1 merged 7 commits intochore_release-8.4.0from
exec-1378-update-evotip-names

Conversation

@sfoster1
Copy link
Copy Markdown
Member

Update the labware definitions for the evotip adapters. These are the existing geometry for the 4 v2 adapters; they're getting new names (and thus going to v1), and they're getting their branding details filled in. We've removed the v1 adapters entirely, since their names were confusingly close to the new ones.

This also adds the adapters to the labware tab and to the labware library. Note that it does not add them to PD; PD can't create evotip protocols, and anyway we only want people to be using these with one specific protocol.

Closes EXEC-1378
Closes EXEC-1364

App labware tab:
Screenshot 2025-03-27 at 1 53 28 PM
Screenshot 2025-03-27 at 1 53 51 PM

Labware library:
Screenshot 2025-03-27 at 1 55 38 PM
Screenshot 2025-03-27 at 1 55 28 PM
Screenshot 2025-03-27 at 1 55 19 PM
Screenshot 2025-03-27 at 1 54 59 PM
Screenshot 2025-03-27 at 1 54 50 PM
Screenshot 2025-03-27 at 1 54 42 PM

@sfoster1 sfoster1 requested review from a team as code owners March 27, 2025 17:59
@sfoster1 sfoster1 requested review from jerader and mjhuff and removed request for a team March 27, 2025 17:59
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 27, 2025

Codecov Report

Attention: Patch coverage is 30.76923% with 9 lines in your changes missing coverage. Please review.

Project coverage is 24.58%. Comparing base (7d1f010) to head (b9012f2).
Report is 3 commits behind head on chore_release-8.4.0.

Files with missing lines Patch % Lines
...rFlow/utils/generateCompatibleLabwareForPipette.ts 0.00% 6 Missing ⚠️
...p/src/organisms/ODD/QuickTransferFlow/constants.ts 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-8.4.0   #17907      +/-   ##
=======================================================
- Coverage                24.59%   24.58%   -0.01%     
=======================================================
  Files                     2935     2935              
  Lines                   225055   225079      +24     
  Branches                 18918    18918              
=======================================================
- Hits                     55344    55340       -4     
- Misses                  169699   169727      +28     
  Partials                    12       12              
Flag Coverage Δ
protocol-designer 18.77% <30.76%> (-0.01%) ⬇️
step-generation 4.34% <30.76%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
shared-data/js/getLabware.ts 70.27% <100.00%> (-1.04%) ⬇️
...p/src/organisms/ODD/QuickTransferFlow/constants.ts 0.00% <0.00%> (ø)
...rFlow/utils/generateCompatibleLabwareForPipette.ts 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sfoster1 sfoster1 requested a review from smb2268 March 27, 2025 19:31
Copy link
Copy Markdown
Contributor

@SyntaxColoring SyntaxColoring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒

@sfoster1
Copy link
Copy Markdown
Member Author

Ran a quick test on a flex and looked ok

Copy link
Copy Markdown
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thanks!

@sfoster1 sfoster1 merged commit 3222edc into chore_release-8.4.0 Mar 27, 2025
79 checks passed
@sfoster1 sfoster1 deleted the exec-1378-update-evotip-names branch March 27, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants