Skip to content

chore(locize): sync for translations needed#18009

Merged
y3rsh merged 3 commits intochore_release-8.4.0from
locize-20250408-eight-four
Apr 9, 2025
Merged

chore(locize): sync for translations needed#18009
y3rsh merged 3 commits intochore_release-8.4.0from
locize-20250408-eight-four

Conversation

@y3rsh
Copy link
Copy Markdown
Member

@y3rsh y3rsh commented Apr 8, 2025

This PR is the result of syncing with locize and then running make format-js

  • Keys that no longer exists in en are removed from zh
  • en and zh files are alphabetized
  • 78 translations are pending and the team is alerted

Leaving this PR open until we have the translations back and can sync again with those new translations.

  • sync translations once complete

There is no reason to merge this yet as it adds no value but does help @y3rsh not forget about this chore 😊

@y3rsh y3rsh self-assigned this Apr 8, 2025
@y3rsh y3rsh requested a review from a team as a code owner April 8, 2025 16:53
@y3rsh y3rsh requested review from mjhuff and removed request for a team April 8, 2025 16:53
@y3rsh y3rsh added the DO NOT MERGE Indicates a PR should not be merged, even if there's a shiny green merge button available label Apr 8, 2025
Copy link
Copy Markdown
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I didn't know your script alphabetizes our i18n files. That's great!

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.61%. Comparing base (39ad078) to head (4af44d4).
Report is 3 commits behind head on chore_release-8.4.0.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-8.4.0   #18009      +/-   ##
=======================================================
- Coverage                28.90%   27.61%   -1.29%     
=======================================================
  Files                     3101     3101              
  Lines                   235465   235479      +14     
  Branches                 19131    19131              
=======================================================
- Hits                     68066    65038    -3028     
- Misses                  167375   170418    +3043     
+ Partials                    24       23       -1     
Flag Coverage Δ
app 1.33% <ø> (-1.89%) ⬇️
labware-library 4.04% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 62 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@y3rsh y3rsh merged commit c0ae03e into chore_release-8.4.0 Apr 9, 2025
37 checks passed
@y3rsh y3rsh deleted the locize-20250408-eight-four branch April 9, 2025 13:34
ahiuchingau pushed a commit that referenced this pull request Apr 9, 2025
y3rsh added a commit that referenced this pull request Apr 9, 2025
…y-path

* chore_release-8.4.0: (30 commits)
  fix(api): make error message clearer for lld issues (#18005)
  chore(locize): sync for translations needed (#18009)
  chore(locize): sync translations (#18009)
  docs(api): API reference entries for liquid class methods (#17887)
  refactor(api): change the names of liquid classes based transfers (#18006)
  feat(app, labware-library): add evotip definition assets (#18007)
  fix(api, shared-data): Flex Stacker engine command optional fields (#17989)
  fix(shared-data): ethanol aspirate position reference (#17991)
  fix(app): Labware setup UI fixes (#17987)
  refactor(app): adjust protocol setup offsets table header (#17985)
  fix(app): do not show post run drop tip prompt if just handled in Error Recovery (#17981)
  fix(app): fix LPC disabled reasons not including fixture mismatch (#17979)
  refactor(app): adjust width on "calibrate now" button (#17978)
  fix(app): fix applying offsets implicitly when navigating on the desktop app (#17967)
  feat(robot-server): Populate `locationSequence` on old runs and make it faster to filter out deleted offsets (#17946)
  feat(app): add inline notification when setting default offsets with a 96ch (#17977)
  fix(app): ER tip selection crashes when trying to get labware def (#17975)
  feat(robot-server,system-server): Return server timing metrics in HTTP responses (#17970)
  fix(app): fix accumulating offsets on run record (#17969)
  fix(app): Fix local state issues when "resetting to default" in LPC (#17965)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DO NOT MERGE Indicates a PR should not be merged, even if there's a shiny green merge button available

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants