Skip to content

fix(api): make error message clearer for lld issues#18005

Merged
caila-marashaj merged 2 commits into
chore_release-8.4.0from
RQA-4052-fix-error-presentation
Apr 9, 2025
Merged

fix(api): make error message clearer for lld issues#18005
caila-marashaj merged 2 commits into
chore_release-8.4.0from
RQA-4052-fix-error-presentation

Conversation

@caila-marashaj
Copy link
Copy Markdown
Contributor

@caila-marashaj caila-marashaj commented Apr 8, 2025

Overview

If you load a well to be empty, then try and dispense at the meniscus, you should only be allowed to do so if the z offset makes it such that the commanded tip height is above the pipette's minimum allowed lld height.

This was implemented fine, but the error message for the case where you'd try and dispense from below the lld height makes it seem as though the tip height might be below the bottom of the well. This is what the new error message will look like:

image

@caila-marashaj caila-marashaj requested a review from a team as a code owner April 8, 2025 15:23
Copy link
Copy Markdown
Contributor

@ecormany ecormany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Can you add a space between the number and units each time that appears?

@caila-marashaj
Copy link
Copy Markdown
Contributor Author

Nice! Can you add a space between the number and units each time that appears?

gotcha

@sfoster1 sfoster1 changed the base branch from edge to chore_release-8.4.0 April 8, 2025 17:00
@sfoster1 sfoster1 requested review from a team as code owners April 8, 2025 17:00
@sfoster1 sfoster1 requested review from ncdiehl11 and removed request for a team April 8, 2025 17:00
@caila-marashaj caila-marashaj force-pushed the RQA-4052-fix-error-presentation branch from d23fcf0 to bf423ce Compare April 8, 2025 17:32
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 8, 2025

Codecov Report

Attention: Patch coverage is 32.27826% with 1947 lines in your changes missing coverage. Please review.

Project coverage is 20.97%. Comparing base (24f5cc5) to head (bf423ce).

Files with missing lines Patch % Lines
...ols/MoveLiquidTools/SecondStepsMoveLiquidTools.tsx 0.28% 350 Missing ⚠️
...StepForm/StepTools/MixTools/SecondStepMixTools.tsx 1.05% 187 Missing ⚠️
protocol-designer/src/steplist/formLevel/errors.ts 19.64% 135 Missing ⚠️
.../ErrorRecoveryFlows/hooks/useFailedLabwareUtils.ts 0.00% 128 Missing ⚠️
.../StepForm/StepTools/MixTools/FirstStepMixTools.tsx 1.81% 108 Missing ⚠️
...organisms/ODD/QuickTransferFlow/utils/pythonDef.ts 0.00% 87 Missing ⚠️
protocol-designer/src/steplist/formLevel/index.ts 8.60% 85 Missing ⚠️
...rotocol-designer/src/step-forms/selectors/index.ts 0.00% 83 Missing ⚠️
app/src/organisms/ErrorRecoveryFlows/constants.ts 0.00% 63 Missing ⚠️
.../organisms/ErrorRecoveryFlows/RecoveryDoorOpen.tsx 0.00% 57 Missing ⚠️
... and 57 more
Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-8.4.0   #18005      +/-   ##
=======================================================
- Coverage                28.90%   20.97%   -7.93%     
=======================================================
  Files                     3101     2881     -220     
  Lines                   235465   221801   -13664     
  Branches                 19131     8453   -10678     
=======================================================
- Hits                     68066    46528   -21538     
- Misses                  167375   175273    +7898     
+ Partials                    24        0      -24     
Flag Coverage Δ
app ?
components ?
hardware ?
labware-library ?
opentrons-ai-client ?
protocol-designer 18.82% <26.50%> (+0.02%) ⬆️
react-api-client ?
shared-data ?
step-generation 4.43% <14.16%> (+0.08%) ⬆️
system-server ?
update-server ?
usb-bridge ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...anisms/ErrorRecoveryFlows/hooks/useShowDoorInfo.ts 0.00% <ø> (ø)
...orRecoveryFlows/shared/RecoveryDoorOpenSpecial.tsx 0.00% <ø> (ø)
app/src/redux/config/schema-types.ts 100.00% <ø> (ø)
...mponents/molecules/DropdownStepFormField/index.tsx 58.82% <100.00%> (+0.70%) ⬆️
...c/components/organisms/AnnouncementModal/index.tsx 96.77% <100.00%> (+0.94%) ⬆️
.../organisms/ConfirmDeleteEntityInUseModal/index.tsx 100.00% <100.00%> (ø)
...gner/src/components/organisms/Navigation/index.tsx 91.07% <ø> (-0.46%) ⬇️
...rotocol-designer/src/components/organisms/index.ts 100.00% <100.00%> (ø)
...src/file-data/__fixtures__/createFile/v7Fixture.ts 100.00% <100.00%> (ø)
...ol-designer/src/file-data/selectors/fileCreator.ts 86.77% <100.00%> (+2.44%) ⬆️
... and 110 more

... and 522 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@caila-marashaj caila-marashaj force-pushed the RQA-4052-fix-error-presentation branch from bf423ce to d4d6461 Compare April 8, 2025 18:36
Copy link
Copy Markdown
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, ty!

@caila-marashaj caila-marashaj merged commit bcb87f6 into chore_release-8.4.0 Apr 9, 2025
24 checks passed
y3rsh added a commit that referenced this pull request Apr 9, 2025
…y-path

* chore_release-8.4.0: (30 commits)
  fix(api): make error message clearer for lld issues (#18005)
  chore(locize): sync for translations needed (#18009)
  chore(locize): sync translations (#18009)
  docs(api): API reference entries for liquid class methods (#17887)
  refactor(api): change the names of liquid classes based transfers (#18006)
  feat(app, labware-library): add evotip definition assets (#18007)
  fix(api, shared-data): Flex Stacker engine command optional fields (#17989)
  fix(shared-data): ethanol aspirate position reference (#17991)
  fix(app): Labware setup UI fixes (#17987)
  refactor(app): adjust protocol setup offsets table header (#17985)
  fix(app): do not show post run drop tip prompt if just handled in Error Recovery (#17981)
  fix(app): fix LPC disabled reasons not including fixture mismatch (#17979)
  refactor(app): adjust width on "calibrate now" button (#17978)
  fix(app): fix applying offsets implicitly when navigating on the desktop app (#17967)
  feat(robot-server): Populate `locationSequence` on old runs and make it faster to filter out deleted offsets (#17946)
  feat(app): add inline notification when setting default offsets with a 96ch (#17977)
  fix(app): ER tip selection crashes when trying to get labware def (#17975)
  feat(robot-server,system-server): Return server timing metrics in HTTP responses (#17970)
  fix(app): fix accumulating offsets on run record (#17969)
  fix(app): Fix local state issues when "resetting to default" in LPC (#17965)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants