Skip to content

fix(app): allow LPCing default offsets for 'stackingOnly' labware in an adapter#17918

Merged
mjhuff merged 1 commit intochore_release-8.4.0from
app_support-stackingonly-quirk-lpc
Mar 28, 2025
Merged

fix(app): allow LPCing default offsets for 'stackingOnly' labware in an adapter#17918
mjhuff merged 1 commit intochore_release-8.4.0from
app_support-stackingonly-quirk-lpc

Conversation

@mjhuff
Copy link
Copy Markdown
Contributor

@mjhuff mjhuff commented Mar 28, 2025

Closes EXEC-1390

Overview

Certain labware should always be LPC'd in an adapter, even when setting a default offset (eg, evotips). To determine whether or not we require an adapter for all offset calculations, we examine the stackingOnly quirk present on the labware definition.

Fortunately, the change for this is pretty minimal - the view layer (including the deck, copy, and load/remove commands), all utilize a couple pieces of state, specifically the closestBeneathAdapterId and lwModOnlyStackupDetails for driving appropriate behavior. Therefore, all we have to do is modify the default offset that is built and injected into LPC, now accounting for the stackingOnly quirk. If the quirk is present, utilize the first adapter the labware is loaded with.

Screen.Recording.2025-03-28.at.9.35.00.AM.mov

Test Plan and Hands on Testing

  • See video.
  • Verified that load/unload commands work as expected.
  • Verified the pipette doesn't plough through evotips with the adapter attached.

Changelog

  • Added default offset support for labware with a stackingOnly property.

Risk assessment

low

@mjhuff mjhuff requested review from a team, SyntaxColoring and sfoster1 March 28, 2025 13:43
@mjhuff mjhuff requested a review from a team as a code owner March 28, 2025 13:43
@mjhuff mjhuff requested review from TamarZanzouri and removed request for a team and TamarZanzouri March 28, 2025 13:43
Copy link
Copy Markdown
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent, way cleaner that I expected it would have to be!

@mjhuff mjhuff merged commit e1eac6f into chore_release-8.4.0 Mar 28, 2025
36 checks passed
@mjhuff mjhuff deleted the app_support-stackingonly-quirk-lpc branch March 28, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants