fix(app): allow LPCing default offsets for 'stackingOnly' labware in an adapter#17918
Merged
mjhuff merged 1 commit intochore_release-8.4.0from Mar 28, 2025
Merged
Conversation
sfoster1
approved these changes
Mar 28, 2025
Member
sfoster1
left a comment
There was a problem hiding this comment.
excellent, way cleaner that I expected it would have to be!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes EXEC-1390
Overview
Certain labware should always be LPC'd in an adapter, even when setting a default offset (eg, evotips). To determine whether or not we require an adapter for all offset calculations, we examine the
stackingOnlyquirk present on the labware definition.Fortunately, the change for this is pretty minimal - the view layer (including the deck, copy, and load/remove commands), all utilize a couple pieces of state, specifically the
closestBeneathAdapterIdandlwModOnlyStackupDetailsfor driving appropriate behavior. Therefore, all we have to do is modify the default offset that is built and injected into LPC, now accounting for thestackingOnlyquirk. If the quirk is present, utilize the first adapter the labware is loaded with.Screen.Recording.2025-03-28.at.9.35.00.AM.mov
Test Plan and Hands on Testing
Changelog
stackingOnlyproperty.Risk assessment
low