Skip to content

fix(app): Do not LPC in staging area slots#17926

Merged
mjhuff merged 1 commit intochore_release-8.4.0from
app_fix-staging-area-slots
Mar 28, 2025
Merged

fix(app): Do not LPC in staging area slots#17926
mjhuff merged 1 commit intochore_release-8.4.0from
app_fix-staging-area-slots

Conversation

@mjhuff
Copy link
Copy Markdown
Contributor

@mjhuff mjhuff commented Mar 28, 2025

Closes RQA-4016

Overview

Yep, believe it or not, we shouldn't LPC in staging area slots. To fix, we just need to mark LPC-able commands as being "not valid" if they are in a staging slot addressable area.

Test Plan and Hands on Testing

  • Using the protocol linked in the ticket, verified the staging slots are not LPC-able, nor appear in the list of LPC-able offsets table.

Changelog

  • Fixed LPCing in staging area slot.

Risk assessment

low

@mjhuff mjhuff requested a review from a team as a code owner March 28, 2025 19:09
@mjhuff mjhuff requested review from a team and smb2268 and removed request for a team and smb2268 March 28, 2025 19:09
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 28, 2025

Codecov Report

Attention: Patch coverage is 39.28571% with 17 lines in your changes missing coverage. Please review.

Project coverage is 25.80%. Comparing base (e1eac6f) to head (0e05b84).
Report is 1 commits behind head on chore_release-8.4.0.

Files with missing lines Patch % Lines
...alidLabwareLocationInfo/appendUniqValidLocCombo.ts 0.00% 17 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-8.4.0   #17926      +/-   ##
=======================================================
- Coverage                25.82%   25.80%   -0.02%     
=======================================================
  Files                     3005     3005              
  Lines                   227433   227630     +197     
  Branches                 18912    18912              
=======================================================
+ Hits                     58724    58735      +11     
- Misses                  168696   168882     +186     
  Partials                    13       13              
Flag Coverage Δ
protocol-designer 18.74% <39.28%> (-0.02%) ⬇️
step-generation 4.34% <39.28%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
shared-data/js/constants.ts 100.00% <100.00%> (ø)
...alidLabwareLocationInfo/appendUniqValidLocCombo.ts 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@mjhuff mjhuff merged commit 6e68ce2 into chore_release-8.4.0 Mar 28, 2025
58 checks passed
@mjhuff mjhuff deleted the app_fix-staging-area-slots branch March 28, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants