fix(app): Do not LPC in staging area slots#17926
Merged
mjhuff merged 1 commit intochore_release-8.4.0from Mar 28, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## chore_release-8.4.0 #17926 +/- ##
=======================================================
- Coverage 25.82% 25.80% -0.02%
=======================================================
Files 3005 3005
Lines 227433 227630 +197
Branches 18912 18912
=======================================================
+ Hits 58724 58735 +11
- Misses 168696 168882 +186
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes RQA-4016
Overview
Yep, believe it or not, we shouldn't LPC in staging area slots. To fix, we just need to mark LPC-able commands as being "not valid" if they are in a staging slot addressable area.
Test Plan and Hands on Testing
Changelog
Risk assessment
low