fix(app): Fix LPC not POSTing labware defs to the maintenance run#17894
Merged
Conversation
mjhuff
requested review from
a team,
SyntaxColoring,
jerader and
sfoster1
and removed request for
a team and
jerader
mjhuff
force-pushed
the
app_fix-custom-lw-lpc
branch
3 times, most recently
from
eb400d7 to
50b74fc
Compare
y3rsh
added a commit
that referenced
this pull request
Mar 27, 2025
…y-path * chore_release-8.4.0: fix(app): Fix LPC not POSTing labware defs to the maintenance run (#17894) feat(shared-data): enable multi dispense blowout (#17895) feat(hardware, api): Add a python-controlled tattle flag for resin tip dispensing (#17851) fix(app): Fix blocking Flex LPC for OT-2 reasons (#17890)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes RQA-4010
Overview
Currently, LPC utilizes the existing labware definitions from
runs/:runId/loaded_labware_defintionsand POSTs those definitions to the LPC maintenance run. However, it turns out that those definitions do not necessarily exist on the run resource at the time of LPC maintenance run creation.We actually have access to the labware definitions from analysis directly and don't need to query the server for them. A much simpler (and functional) approach is to just POST the definitions we already have.
Current Behavior
Screen.Recording.2025-03-26.at.4.19.54.PM.mov
With Fix
Screen.Recording.2025-03-26.at.4.14.17.PM.mov
Test Plan and Hands on Testing
Changelog
Risk assessment
low