Skip to content

refactor(app): Add OT-2 LPC "skip" and immediately apply offsets#17902

Merged
mjhuff merged 11 commits intochore_release-8.4.0from
app_ot2-lpc-improvements
Mar 27, 2025
Merged

refactor(app): Add OT-2 LPC "skip" and immediately apply offsets#17902
mjhuff merged 11 commits intochore_release-8.4.0from
app_ot2-lpc-improvements

Conversation

@mjhuff
Copy link
Copy Markdown
Contributor

@mjhuff mjhuff commented Mar 27, 2025

Closes EXEC-1360

Overview

Adds the scoped LPC Redesign functionality for the OT-2:

  • Skipping! You can now choose not to LPC a tip rack or a labware. You still can't skip the "attach tip" and "detach tip" step for obvious reasons, though. See 68df792 and b69c9d1.
  • Applying offsets after each step! Yes, exiting LPC early means you do get to keep the offset data that you set or previously existed. See ab60a54

The rest of the commits are supportive copy/loading state changes.

Screen.Recording.2025-03-27.at.12.10.46.PM.mov

The video does not show "skip" for tip racks - this was recorded before that was added.

Test Plan and Hands on Testing

  • See video.
  • Tested a few protocols, ensuring the run record reflects the posted offsets.

Changelog

  • OT-2 LPC now supports skipping setting an offset for a labware.
  • OT-2 LPC now applies the offset after confirming the offset position.

Risk assessment

highish. This does touch critical flows on the OT-2.

@mjhuff mjhuff requested review from a team, SyntaxColoring and sfoster1 March 27, 2025 16:45
@mjhuff mjhuff requested a review from a team as a code owner March 27, 2025 16:45
@mjhuff mjhuff requested review from koji and removed request for a team and koji March 27, 2025 16:45
@mjhuff mjhuff changed the title App ot2 lpc improvements refactor(app): Add OT-2 lpc improvements Mar 27, 2025
@mjhuff mjhuff changed the title refactor(app): Add OT-2 lpc improvements refactor(app): Add OT-2 LPC improvements Mar 27, 2025
@mjhuff mjhuff changed the title refactor(app): Add OT-2 LPC improvements refactor(app): Add OT-2 LPC "skip" and immediately apply offsets Mar 27, 2025
Copy link
Copy Markdown
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 27, 2025

Codecov Report

Attention: Patch coverage is 0% with 181 lines in your changes missing coverage. Please review.

Project coverage is 25.46%. Comparing base (e92d8ce) to head (12decdf).
Report is 4 commits behind head on chore_release-8.4.0.

Files with missing lines Patch % Lines
...itionCheck/LegacyLabwarePositionCheckComponent.tsx 0.00% 73 Missing ⚠️
...organisms/LegacyLabwarePositionCheck/JogToWell.tsx 0.00% 19 Missing ⚠️
...organisms/LegacyLabwarePositionCheck/PickUpTip.tsx 0.00% 19 Missing ⚠️
...organisms/LegacyLabwarePositionCheck/CheckItem.tsx 0.00% 18 Missing ⚠️
...anisms/LegacyLabwarePositionCheck/PrepareSpace.tsx 0.00% 17 Missing ⚠️
...isms/LegacyLabwarePositionCheck/ResultsSummary.tsx 0.00% 13 Missing ⚠️
...un/SetupLabwarePositionCheck/OT2SetupLPC/index.tsx 0.00% 11 Missing ⚠️
...nisms/LabwarePositionCheck/LPCFlows/useLPCFlows.ts 0.00% 5 Missing ⚠️
...arePositionCheck/FlexSetupLPC/LPCSetupFlexBtns.tsx 0.00% 2 Missing ⚠️
...organisms/LegacyLabwarePositionCheck/ReturnTip.tsx 0.00% 2 Missing ⚠️
... and 2 more
Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-8.4.0   #17902      +/-   ##
=======================================================
+ Coverage                24.59%   25.46%   +0.87%     
=======================================================
  Files                     2935     2935              
  Lines                   225053   225123      +70     
  Branches                 18918    18911       -7     
=======================================================
+ Hits                     55344    57323    +1979     
+ Misses                  169697   167787    -1910     
- Partials                    12       13       +1     
Flag Coverage Δ
app 3.20% <0.00%> (+0.89%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ganisms/LabwarePositionCheck/LPCFlows/LPCFlows.tsx 0.00% <ø> (ø)
...src/organisms/LegacyLabwarePositionCheck/index.tsx 0.00% <ø> (ø)
.../organisms/LabwareOffsetsTable/AccordionDetail.tsx 0.00% <0.00%> (ø)
...anisms/LabwarePositionCheck/LPCWizardContainer.tsx 0.00% <0.00%> (ø)
...arePositionCheck/FlexSetupLPC/LPCSetupFlexBtns.tsx 0.00% <0.00%> (ø)
...organisms/LegacyLabwarePositionCheck/ReturnTip.tsx 0.00% <0.00%> (ø)
...nisms/LabwarePositionCheck/LPCFlows/useLPCFlows.ts 0.00% <0.00%> (ø)
...un/SetupLabwarePositionCheck/OT2SetupLPC/index.tsx 0.00% <0.00%> (ø)
...isms/LegacyLabwarePositionCheck/ResultsSummary.tsx 0.00% <0.00%> (ø)
...anisms/LegacyLabwarePositionCheck/PrepareSpace.tsx 0.00% <0.00%> (ø)
... and 4 more

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mjhuff mjhuff merged commit f96192f into chore_release-8.4.0 Mar 27, 2025
31 of 32 checks passed
@mjhuff mjhuff deleted the app_ot2-lpc-improvements branch March 27, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants