perf(robot-server): Optimize adding many offsets at once through POST /labwareOffsets#17952
Merged
SyntaxColoring merged 1 commit intochore_release-8.4.0from Apr 1, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
An HTTP client can upload multiple labware offsets to the robot server in a single
POST /labwareOffsetsrequest. Formerly, each offset was running in its own SQL transaction, which was slow. This wraps all of the insertions in a single transaction, which is much faster, in addition to being more atomic.Inserting 1000 offsets on an OT-2 goes from ~210s (~210ms/offset) to ~22s (~22ms/offset).
Test Plan and Hands on Testing
We're covered by existing automated tests, but I also tried this manually on an OT-2.
Review requests
None in particular.
Risk assessment
Low. Changes are pretty trivial.