fix(hardware): handle usage responses better#17942
Merged
sfoster1 merged 1 commit intochore_release-8.4.0from Mar 31, 2025
Merged
fix(hardware): handle usage responses better#17942sfoster1 merged 1 commit intochore_release-8.4.0from
sfoster1 merged 1 commit intochore_release-8.4.0from
Conversation
Usages were failing if the node wasn't listed. I think this happens because we do the usage request sometimes before we've registered all the nodes but I'm not sure, so let's at least get rid of the exception and add some logs to help figure out the context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usages were failing if the node wasn't listed. I think this happens because we do the usage request sometimes before we've registered all the nodes but I'm not sure, so let's at least get rid of the exception and add some logs to help figure out the context.