Skip to content

chore(shared-data): show tiprack lid in LL#17925

Merged
sfoster1 merged 1 commit intochore_release-8.4.0from
show-tiprack-lid-in-labware
Mar 28, 2025
Merged

chore(shared-data): show tiprack lid in LL#17925
sfoster1 merged 1 commit intochore_release-8.4.0from
show-tiprack-lid-in-labware

Conversation

@sfoster1
Copy link
Copy Markdown
Member

What it says on the tin, removes the tiprack lid labware from the blocklist. You don't buy this on its own so it doesn't have branding details and a sku.

@sfoster1 sfoster1 requested a review from a team as a code owner March 28, 2025 18:27
@sfoster1 sfoster1 requested review from jerader and mjhuff and removed request for a team March 28, 2025 18:27
@sfoster1 sfoster1 force-pushed the show-tiprack-lid-in-labware branch from 1aee100 to f78419e Compare March 28, 2025 18:30
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.82%. Comparing base (e1eac6f) to head (f78419e).
Report is 7 commits behind head on chore_release-8.4.0.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-8.4.0   #17925      +/-   ##
=======================================================
- Coverage                25.82%   25.82%   -0.01%     
=======================================================
  Files                     3005     3005              
  Lines                   227433   227432       -1     
  Branches                 18912    18912              
=======================================================
- Hits                     58724    58723       -1     
  Misses                  168696   168696              
  Partials                    13       13              
Flag Coverage Δ
protocol-designer 18.75% <ø> (-0.01%) ⬇️
step-generation 4.34% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
shared-data/js/getLabware.ts 70.00% <ø> (-0.28%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Copy Markdown
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jerader
Copy link
Copy Markdown
Collaborator

jerader commented Mar 28, 2025

are we going to cut LL's release off of chore_release-8.4.0? or should we merge chore_release-8.4.0 into edge and cut off of edge?

@sfoster1 sfoster1 merged commit e121992 into chore_release-8.4.0 Mar 28, 2025
57 checks passed
@sfoster1 sfoster1 deleted the show-tiprack-lid-in-labware branch March 28, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants