fix(app): do not infinitely jog during LPC#17934
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## chore_release-8.4.0 #17934 +/- ##
=======================================================
- Coverage 28.74% 27.90% -0.84%
=======================================================
Files 3111 3111
Lines 236770 236797 +27
Branches 19221 19220 -1
=======================================================
- Hits 68053 66084 -1969
- Misses 168693 170690 +1997
+ Partials 24 23 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes RQA-4017 and RQA-4011
Overview
On the physical ODD, it's possible queue jog commands in such a way that jog commands execute indefinitely. This issue was caused by using React async state updates to trigger queue processing. This PR rewrites the code to use refs for avoiding React asynchronous state updates, and also use Lodash's lovely
debounceutil, helping to improve the control flow.Test Plan and Hands on Testing
Changelog
Risk assessment
low