Skip to content

fix(app): do not infinitely jog during LPC#17934

Merged
mjhuff merged 1 commit into
chore_release-8.4.0from
app_fix-lpc-jog-controls
Apr 1, 2025
Merged

fix(app): do not infinitely jog during LPC#17934
mjhuff merged 1 commit into
chore_release-8.4.0from
app_fix-lpc-jog-controls

Conversation

@mjhuff
Copy link
Copy Markdown
Contributor

@mjhuff mjhuff commented Mar 31, 2025

Closes RQA-4017 and RQA-4011

Overview

On the physical ODD, it's possible queue jog commands in such a way that jog commands execute indefinitely. This issue was caused by using React async state updates to trigger queue processing. This PR rewrites the code to use refs for avoiding React asynchronous state updates, and also use Lodash's lovely debounce util, helping to improve the control flow.

Test Plan and Hands on Testing

  • Repro'd the issue readily on the physical ODD by pressing exactly three times in rapid succession.
  • With PR, verified that jog controls do not jog indefinitely on the desktop and ODD.

Changelog

  • Fixed jogging during LPC on the ODD causing infinite jogs.

Risk assessment

low

@mjhuff mjhuff requested review from a team, SyntaxColoring and sfoster1 March 31, 2025 14:48
@mjhuff mjhuff requested a review from a team as a code owner March 31, 2025 14:48
@mjhuff mjhuff requested review from jerader and removed request for a team and jerader March 31, 2025 14:48
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 31, 2025

Codecov Report

Attention: Patch coverage is 0% with 81 lines in your changes missing coverage. Please review.

Project coverage is 27.90%. Comparing base (6187fb3) to head (8da9a29).
Report is 2 commits behind head on chore_release-8.4.0.

Files with missing lines Patch % Lines
...PositionCheck/hooks/useLPCCommands/useHandleJog.ts 0.00% 81 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-8.4.0   #17934      +/-   ##
=======================================================
- Coverage                28.74%   27.90%   -0.84%     
=======================================================
  Files                     3111     3111              
  Lines                   236770   236797      +27     
  Branches                 19221    19220       -1     
=======================================================
- Hits                     68053    66084    -1969     
- Misses                  168693   170690    +1997     
+ Partials                    24       23       -1     
Flag Coverage Δ
app 2.31% <0.00%> (-0.90%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...PositionCheck/hooks/useLPCCommands/useHandleJog.ts 0.00% <0.00%> (ø)

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof

@mjhuff mjhuff merged commit 158c453 into chore_release-8.4.0 Apr 1, 2025
37 of 38 checks passed
@mjhuff mjhuff deleted the app_fix-lpc-jog-controls branch April 1, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants