feat(app): Add default offset info banner to LPC#17923
feat(app): Add default offset info banner to LPC#17923mjhuff merged 6 commits intochore_release-8.4.0from
Conversation
b9a4753 to
039f25c
Compare
| // Holds state & functionality for managing banners that require app-wide persistent state. | ||
| // If state should persist between LPC wizard sessions, use Redux instead! |
There was a problem hiding this comment.
Nit: this comment is a little confusing to me because "app-wide persistent state" sounds to me like the same thing as "state that should persist between LPC wizard sessions."
There was a problem hiding this comment.
Separately, for my edification, why not use Redux for this? Just overkill?
There was a problem hiding this comment.
Sorry, yeah, that comment is a bit confusing. I'll update it.
Redux is honestly fine, good point. We'd have to reset the banner state when we close the app for the correct behavior, which seems a bit clunky to me, but I still might throw it in Redux just to keep things consistent.
EDIT: Due to time constraints, I've left a TODO here.
There was a problem hiding this comment.
We'd have to reset the banner state when we close the app for the correct behavior
Oh whoa, does our redux state persist across app launches?
There was a problem hiding this comment.
Sorry, confusing response on my part. I meant when we close the LPC wizard flows, NOT the app, since LPC state is persisted for a given protocol run indefinitely as long as the app is open. Closing the app definitely resets state (at least all the state that is not persisted in config)!
855026d to
dd4d534
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## chore_release-8.4.0 #17923 +/- ##
=======================================================
- Coverage 25.82% 25.68% -0.14%
=======================================================
Files 3005 3014 +9
Lines 227433 229241 +1808
Branches 18912 18993 +81
=======================================================
+ Hits 58724 58884 +160
- Misses 168696 170344 +1648
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
4d8cebf to
557bac9
Compare
265899c to
2d44ec2
Compare
Closes EXEC-1392 and RQA-4018
Overview
After QA feedback, Design has decided to add an info banner that includes an explanation of default offsets. The banner should persist for one LPC wizard session, so this is state is kept in the general wizard container.
Note that designs show tooltips for the desktop app, but after convo with Design, we're just doing the banner for both.
Screen.Recording.2025-03-28.at.12.29.21.PM.mov
Test Plan and Hands on Testing
Changelog
Risk assessment
low