fix(app): fix not applying offsets for locations containing modules#17901
Merged
Conversation
mjhuff
requested review from
TamarZanzouri
and removed request for
a team and
TamarZanzouri
sfoster1
approved these changes
Mar 27, 2025
Member
sfoster1
left a comment
sfoster1
left a comment
There was a problem hiding this comment.
yeah, sorry. thanks for fixing it!
we should really have tests for this kind of straightforward data transformation though
Contributor
Author
Yep, for sure, it's on my TODO list, see EXEC-1352 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes RQA-4012
Overview
Fixes an issue applying offsets when the
offsetLocationSequenceinvolves a module. The util that converts thelocationSequenceto anoffsetLocationSequenceassumed that the ordering of the sequence should translate 1:1, but foroffsetLocationSequence, theaddressableAreakind component must be last in order to successfully POST updates for the offset.Test Plan and Hands on Testing
Changelog
Risk assessment
low