fix(app): Fix Desktop LPC "apply offsets" state#17940
Merged
Merged
Conversation
sfoster1
approved these changes
Mar 31, 2025
Member
sfoster1
left a comment
There was a problem hiding this comment.
At last, a textbook useEffect! I knew that textbook would be useful one of these days
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes RQA-4022
Overview
Woops, the "apply offsets" button disabled status utilized different state than the copy that would render the "offsets applied/not applied". These should be the same. More importantly, on the desktop, if a different user applied offsets, the
missingStepswould not filter out LPC, since it was directly tied to a CTA.Additionally, after talking to Design/QA, we've decided that when applying offsets, the "launch LPC" button should be disabled, too.
Test Plan and Hands on Testing
Changelog
Risk assessment
low