Skip to content

fix(app): Fix Desktop LPC "apply offsets" state#17940

Merged
mjhuff merged 1 commit into
chore_release-8.4.0from
app_fix-desktop-lpc-apply
Mar 31, 2025
Merged

fix(app): Fix Desktop LPC "apply offsets" state#17940
mjhuff merged 1 commit into
chore_release-8.4.0from
app_fix-desktop-lpc-apply

Conversation

@mjhuff
Copy link
Copy Markdown
Contributor

@mjhuff mjhuff commented Mar 31, 2025

Closes RQA-4022

Overview

Woops, the "apply offsets" button disabled status utilized different state than the copy that would render the "offsets applied/not applied". These should be the same. More importantly, on the desktop, if a different user applied offsets, the missingSteps would not filter out LPC, since it was directly tied to a CTA.

Additionally, after talking to Design/QA, we've decided that when applying offsets, the "launch LPC" button should be disabled, too.

Test Plan and Hands on Testing

  • Verified the state sync issue mentioned in the ticket is fixed.
  • Verified that after applying offsets, the "launch LPC" button is disabled, too.

Changelog

  • Fixed the desktop app sometimes not allowing users to apply offsets.

Risk assessment

low

@mjhuff mjhuff requested review from a team, SyntaxColoring and sfoster1 March 31, 2025 19:15
@mjhuff mjhuff requested a review from a team as a code owner March 31, 2025 19:15
@mjhuff mjhuff requested review from koji and removed request for a team and koji March 31, 2025 19:15
Copy link
Copy Markdown
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At last, a textbook useEffect! I knew that textbook would be useful one of these days

@mjhuff mjhuff merged commit f134eb4 into chore_release-8.4.0 Mar 31, 2025
36 checks passed
@mjhuff mjhuff deleted the app_fix-desktop-lpc-apply branch March 31, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants