feat(shared-data): enable multi dispense blowout#17895
Merged
sanni-t merged 2 commits intochore_release-8.4.0from Mar 27, 2025
Merged
feat(shared-data): enable multi dispense blowout#17895sanni-t merged 2 commits intochore_release-8.4.0from
sanni-t merged 2 commits intochore_release-8.4.0from
Conversation
sanni-t
requested review from
andySigler and
y3rsh
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## chore_release-8.4.0 #17895 +/- ##
========================================================
+ Coverage 25.47% 62.62% +37.15%
========================================================
Files 2935 2935
Lines 225042 225237 +195
Branches 18918 19273 +355
========================================================
+ Hits 57323 141065 +83742
+ Misses 167706 83992 -83714
- Partials 13 180 +167
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Member
|
I think this covers all 3 of these and I will test once merged. |
andySigler
approved these changes
Mar 27, 2025
y3rsh
added a commit
that referenced
this pull request
Mar 27, 2025
…y-path * chore_release-8.4.0: fix(app): Fix LPC not POSTing labware defs to the maintenance run (#17894) feat(shared-data): enable multi dispense blowout (#17895) feat(hardware, api): Add a python-controlled tattle flag for resin tip dispensing (#17851) fix(app): Fix blocking Flex LPC for OT-2 reasons (#17890)
sanni-t
added a commit
that referenced
this pull request
Mar 28, 2025
# Overview Realized a few wrong values in my previous PR #17895. The multi-disp blowout flow rates are supposed to be the max of the single dispense flow rates for that pipette+tiprack. A couple of entries got min values instead. Fixed those ## Risk assessment Low. Small fixes in definitions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes RQA-3980
Potentially closes AUTH-1602, AUTH-1619
Overview
Updates all liquid classes' multi-dispense blowout entries to:
trashTest Plan and Hands on Testing
The protocols in RQA-3908 should pass
Review requests
trashRisk assessment
Low. Just enables a setting that was disabled by default. We already have tests that check that transfers happen correctly when these properties are enabled