Skip to content

test(api): liquid classes blowout properties#17875

Merged
y3rsh merged 3 commits intochore_release-8.4.0from
AUTH-1557_build_blowout_properties-test
Mar 25, 2025
Merged

test(api): liquid classes blowout properties#17875
y3rsh merged 3 commits intochore_release-8.4.0from
AUTH-1557_build_blowout_properties-test

Conversation

@y3rsh
Copy link
Copy Markdown
Member

@y3rsh y3rsh commented Mar 25, 2025

This pull request includes changes to improve the validation of flow rates and enhance the testing of blowout properties in the Opentrons protocol API. The most important changes include updating validation methods, adding comprehensive tests for blowout properties, and adjusting schema definitions to enforce stricter validation rules.

Validation improvements:

Testing enhancements:

Schema adjustments:

@y3rsh y3rsh self-assigned this Mar 25, 2025
@y3rsh y3rsh requested review from a team as code owners March 25, 2025 16:24
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.67%. Comparing base (d24ab3b) to head (813ab62).
Report is 5 commits behind head on chore_release-8.4.0.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-8.4.0   #17875      +/-   ##
=======================================================
+ Coverage                24.65%   24.67%   +0.01%     
=======================================================
  Files                     2929     2929              
  Lines                   224422   224403      -19     
  Branches                 18915    18915              
=======================================================
+ Hits                     55337    55367      +30     
+ Misses                  169073   169024      -49     
  Partials                    12       12              
Flag Coverage Δ
app 2.32% <ø> (+<0.01%) ⬆️
protocol-designer 18.77% <ø> (ø)
step-generation 4.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...red_data/liquid_classes/liquid_class_definition.py 95.07% <ø> (-0.07%) ⬇️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@sanni-t sanni-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

"exclusiveMinimum": 0.0,
"type": "number"
}
],
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oo this is confusing. We have a BlowOutParams and a BlowoutParams 🙈

@y3rsh y3rsh changed the base branch from edge to chore_release-8.4.0 March 25, 2025 22:55
@y3rsh y3rsh merged commit abc6bfb into chore_release-8.4.0 Mar 25, 2025
@y3rsh y3rsh deleted the AUTH-1557_build_blowout_properties-test branch March 25, 2025 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants