test(api): liquid classes blowout properties#17875
Merged
y3rsh merged 3 commits intochore_release-8.4.0from Mar 25, 2025
Merged
test(api): liquid classes blowout properties#17875y3rsh merged 3 commits intochore_release-8.4.0from
y3rsh merged 3 commits intochore_release-8.4.0from
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## chore_release-8.4.0 #17875 +/- ##
=======================================================
+ Coverage 24.65% 24.67% +0.01%
=======================================================
Files 2929 2929
Lines 224422 224403 -19
Branches 18915 18915
=======================================================
+ Hits 55337 55367 +30
+ Misses 169073 169024 -49
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
sanni-t
approved these changes
Mar 25, 2025
| "exclusiveMinimum": 0.0, | ||
| "type": "number" | ||
| } | ||
| ], |
Member
There was a problem hiding this comment.
Oo this is confusing. We have a BlowOutParams and a BlowoutParams 🙈
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to improve the validation of flow rates and enhance the testing of blowout properties in the Opentrons protocol API. The most important changes include updating validation methods, adding comprehensive tests for blowout properties, and adjusting schema definitions to enforce stricter validation rules.
Validation improvements:
api/src/opentrons/protocol_api/_liquid_properties.py: Updated theflow_ratesetter to useensure_greater_than_zero_floatfor validation.shared-data/python/opentrons_shared_data/liquid_classes/liquid_class_definition.py: Changed theflowRatefield inBlowoutParamsto use_GreaterThanZeroNumberand updated theenablefield inBlowoutPropertiesto useStrictBool.Testing enhancements:
api/tests/opentrons/protocol_api/test_lc_blowout_properties.py: Added comprehensive tests for blowout properties, including tests for enabling/disabling, validation ofNonevalues, invalid enable values, valid/invalid flow rates, and valid/invalid location values.Schema adjustments:
shared-data/command/schemas/12.json: Modified the schema to useexclusiveMinimumfor flow rate validation, ensuring that flow rates must be greater than zero.