Skip to content

fix(app): remove display of offset vector in labware overlay on setup map#17950

Merged
smb2268 merged 4 commits into
chore_release-8.4.0from
app_fix-labware-location
Apr 1, 2025
Merged

fix(app): remove display of offset vector in labware overlay on setup map#17950
smb2268 merged 4 commits into
chore_release-8.4.0from
app_fix-labware-location

Conversation

@smb2268
Copy link
Copy Markdown
Contributor

@smb2268 smb2268 commented Apr 1, 2025

fix RQA-4025

Overview

Some legacy code was checking for a vector to display LPC information in the labware setup map and couldn't find the location of new lid/lid stack labware, which caused a white screen. We don't want to display offset info here even if it exists, so I've ripped out the code that caused this issue.

Test Plan and Hands on Testing

Start setup using the protocol attached to this bug ticket - see that the error no longer occurs.

Changelog

Remove vector and location logic from LabwareInfoOverlay

Review requests

Quick code check

Risk assessment

Low, all legacy and unused code being removed

@smb2268 smb2268 requested a review from mjhuff April 1, 2025 17:15
@smb2268 smb2268 self-assigned this Apr 1, 2025
@smb2268 smb2268 requested a review from a team as a code owner April 1, 2025 17:15
Copy link
Copy Markdown
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 1, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 28.73%. Comparing base (a84f4e1) to head (7eebce5).
Report is 2 commits behind head on chore_release-8.4.0.

Files with missing lines Patch % Lines
...Desktop/Devices/ProtocolRun/LabwareInfoOverlay.tsx 0.00% 3 Missing ⚠️
...vices/ProtocolRun/SetupLabware/SetupLabwareMap.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-8.4.0   #17950      +/-   ##
=======================================================
- Coverage                28.74%   28.73%   -0.01%     
=======================================================
  Files                     3111     3111              
  Lines                   236770   236825      +55     
  Branches                 19221    19219       -2     
=======================================================
+ Hits                     68053    68063      +10     
- Misses                  168693   168738      +45     
  Partials                    24       24              
Flag Coverage Δ
app 3.21% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...vices/ProtocolRun/SetupLabware/SetupLabwareMap.tsx 0.00% <0.00%> (ø)
...Desktop/Devices/ProtocolRun/LabwareInfoOverlay.tsx 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@smb2268 smb2268 merged commit 0bf9489 into chore_release-8.4.0 Apr 1, 2025
30 checks passed
@smb2268 smb2268 deleted the app_fix-labware-location branch April 1, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants