Merged
Conversation
**Why**: To minimize the chances we accidentally log sensitive credentials
**Why**: - Unused - Simplify future effort to migrate from BassCSS button (`.btn`) styles Last referenced in 8542f03 via removed `Idv::Base#modal_class_name`
**Why**: To differentiate from USPS in-person proofing
* Read the app configs from S3 when we start the app **Why**: So that the IDP does not depend on special files being in the right place on the disk when it starts. Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov>
**Why**: The logic which renders the `totp_partial` and `piv_cac_partial` occurs within a loop of current TOTP and PIV/CAC configurations, and as such could never render anything other than the "disable" (delete) configuration case.
**Why**: As part of LG-3865, will be eliminating BassCSS buttons as a dependency. Account action buttons currently inherit styles from BassCSS, and there is not a standalone design system alternative.
* No longer autocorrecting the email field (Safari only) (LG-3842) * specs
* LG-4305: Log new event in case of lockout from proofing **Why**: As a login.gov developer, i want to see an event in the event log that indicates that a user was locked out for 6 hours from proofing along with the relevant data points that directly resulted in that lockout, so that I can troubleshoot any issues reported by end users and pinpoint exactly what caused the lock out. * Track throttled in index routes for verify controllers See: #4829 (comment) * Redirect to form after failure **Why**: So throttled template would be rendered if failure results in throttle See: #4829 (comment) * Persist errors through verify redirect See: #4829 (comment)
- Catches the error and adds some redacted logging so we can try to understand the data we were sending
* remove some lambda * remove lambda jobs git ref
* LG-4381: Log Acuant SDK load on frontend **Why**: To better understand issues that users may be having in completing the document capture step of the IAL2 flow, we should have insight into potential Acuant SDK load failures. * Fix lines reference URL hash fragment
Bumps [y18n](https://github.com/yargs/y18n) from 4.0.0 to 4.0.1. - [Release notes](https://github.com/yargs/y18n/releases) - [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md) - [Commits](https://github.com/yargs/y18n/commits) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
**Why**: It is disabled in all environments including local development, and its continued existence has proven to be an unnecessary maintenance burden. See: - #3042 - https://github.com/18F/identity-idp/commits/main/app/views/idv/in_person
* Try updating db seed to get around issue with adding columns * Move fingerprinting "up", remove ServiceProviderConfig class * Remove lingering references to old fingerprint * Plumb fingerprint in to saml_idp.service_provider directly
* Update SMS OTP/TOTP app layouts to support USWDS buttons **Why**: In order to support design system buttons guidance as part of LG-3865, layouts for the SMS OTP entry and TOTP app setup should be revised. * Use mobile-lg as breakpoint for copy button offset **Why**: Breaks together with flex wrapping * Position icon button as adjacent (centered) content **Why**: Avoid showing icon to the left of the button in a full-width button. * Show TOTP code as bold text * Match IDV OTP verification to sign-in / sign-up * Remove non-visible required HTML from OTP verificatoin See: https://github.com/18F/identity-idp/pull/4854/files?diff=unified&w=1#r604217085 * Force IDV OTP resend button to render as button tag **Why**: button_to defaults to an input element, which can't have a pseudo-element used for rendering the refresh icon. When using a block statement, button_to renders a button instead, which can support pseudo-elements.
**Why**: - We hide it anyways, both visually and from assistive technology - If it were to be visible, it would use non-standard red color instead of design system (facilitates LG-3877) See: #4854 (comment)
**Why**: As of the upgrade from Acuant SDK v11.4.1 to v11.4.3, a new "moire" property is included in the result.
* Configuration class to check types and presence Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> Co-authored-by: Jonathan Hooper <jonathan.hooper@gsa.gov> * convert some config keys * use redacted struct * Update lib/identity_config.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> Co-authored-by: Jonathan Hooper <jonathan.hooper@gsa.gov>
* LG-3865: Remove BassCSS Module: Btn **Why**: As a user, I expect that login.gov has a consistent visual style, and that my page load times are not prolonged by loading redundant CSS. As a developer, I expect that existing references to BassCSS module classes are replaced with equivalent USWDS or ad hoc alternatives, so that we can successfully migrate away from and eliminate our dependency on BassCSS. * Use outline button for btn-border buttons * Add isBig prop to Button component * Use "big" style button as default for form screens * Avoid setting "Big" as default via SimpleForm config **Why**: While it's the standard button size for most form buttons, notably the "unstyled" button doesn't unset big appearance, and in most all usage we'd not want unstyled buttons to appear large. Also good to be explicit even if standard, since "big" should arguably be a conscious decision for a form button.
* add job subscriber logger * simplify config * consolidate common attributes * ensure job specs call subscriber events
* LG-4396: Log frontend Acuant capture failure **Why**: So that we have insight into the reasons that a capture fails: - The cropping fails - The camera is not supported - The camera has already been started - The page is misconfigured and missing HTML elements required by Acuant - The user or system denies access to their camera * Test error instanceof Error **Why**: MediaStreamError is not defined on global. Rather, it's an interface of an expected format of Error * Add cropping failure references * Refactor analyticsPrefix as name **Why**: To allow flexibility in analytics logging to be used in either event name or as a payload property * Set field name as property of image capture failed log **Why**: Since not part of a funnel, optimize for querying by event name irrespective field name, while retaining field name as property of the event * Fix typos with error strings
…4878) **Why**: Because if these configs are nil they will prevent the app from starting
**Why**: `continue_bttn_class` is only referenced on the depleted view, despite being a method defined on the BackupCodeCreatePresenter class. Since the create view itself hard-codes the same big, wide button as other backup code views, there is no variation of the classes between presenters and it can be removed. Similarly, the text "Continue" is the same between the create and depleted views, despite using separate locale string keys. Instead, consolidate to the "forms.buttons.continue" and remove the helper method.
* Support flexible width button * Render "Take picture" as flexible width button * Float unstyled button as inline adjacent * Make buttons wide * Show spinner button at inline block only at desktop viewports **Why**: Button should occupy full width at smaller viewport widths * Remove unused inline form **Why**: Unused, and doesn't match desired visual style * Remove width-auto from unstyled button in AcuantCapture Not necessary after changing to render unstyled buttons as inline * Unset full-width from unstyled button defaults **Why**: As per purpose of inline styling, should inherit appearance of a link and not occupy 100% width from usa-button base styles * Remove unnecessary unstyled button styles from links Unstyled buttons are intended to take the appearance of a link. Links don't need those styles * Emulate unstyled button margin with padding **Why**: Unstyled buttons override margin and take precedent over USWDS margin utility classes. Emulate by adding padding to the container instead * Fix class name padding-left to padding-left-1
* LG-4428: remove noisy saml request logging * update saml_idp version
* Fix active, disabled, unstyled button background color **Why**: When an unstyled button is used as the submit button in a form, it can cause an issue where clicking the button would make it both disabled and active. This is because our default form validation will disable all submit buttons when a form is submitted. Since this happens at the same time as the link activation, and since the USWDS default disabled button styles conflict with the unstyled link appearance, an undesirable background color can be shown. * Match full selector chain from disabled styles
* log throttle events for email sending throttles * log throttle events for email sending throttles * spec for password reset throttling * fix formatting
LG-4327 First pass image metric errors for DPI, Blur, and Glare for vendor response.
* Add Block Link partial **Why**: Consistency, deduplication * Use Block Link component for Return to SP / Reset links **Why**: Fix block link behavior broken by USWDS migration * Assign Reactivate Account button as full width **Why** Intended with previous `block` styling, now not applied due to button inline-block override * s/return_to_sp_failure_to_proof_path/account_reset_request_path See: https://github.com/18F/identity-idp/pull/4886/files#r609042837 * Block Link: Throw if no block content given Why: https://github.com/18F/identity-idp/pull/4886/files#r608794415
aduth
requested review from
jmhooper,
mitchellhenke,
solipet and
zachmargolis
and removed request for
mitchellhenke and
zachmargolis
zachmargolis
reviewed
Apr 7, 2021
aduth
force-pushed
the
stages/rc-2021-04-08
branch
from
4255023 to
97795fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.